Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 23176002: Fixed HMul::Canonicalize() to support SMI (Closed)

Created:
7 years, 4 months ago by weiliang.lin2
Modified:
7 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@master
Visibility:
Public.

Description

Fixed HMul::Canonicalize() to support SMI Same idea for HDiv when the right oeprand is 1 BUG= R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/hydrogen-instructions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/property-details.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
weiliang.lin2
7 years, 4 months ago (2013-08-14 07:56:36 UTC) #1
Jakob Kummerow
LGTM. I'll land this next week.
7 years, 4 months ago (2013-08-14 13:03:03 UTC) #2
Jakob Kummerow
7 years, 3 months ago (2013-08-27 14:09:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16364 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698