Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2317593002: dbus: No dbus::FileDescriptor in BluetoothMediaTransportClient (Closed)

Created:
4 years, 3 months ago by hashimoto
Modified:
4 years, 3 months ago
Reviewers:
Rahul Chaturvedi
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

dbus: No dbus::FileDescriptor in BluetoothMediaTransportClient Replace dbus::FileDescriptor with base::ScopedFD. BUG=621841 Committed: https://crrev.com/0592d0cdc43c6928f220ac379f76260e7e31c019 Cr-Commit-Position: refs/heads/master@{#417205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M device/bluetooth/bluez/bluetooth_audio_sink_bluez.h View 2 chunks +1 line, -2 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_audio_sink_bluez.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_media_transport_client.h View 2 chunks +4 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_media_transport_client.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_media_transport_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
hashimoto
PTL
4 years, 3 months ago (2016-09-06 08:19:10 UTC) #4
Rahul Chaturvedi
lgtm
4 years, 3 months ago (2016-09-07 21:18:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317593002/1
4 years, 3 months ago (2016-09-08 03:31:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 06:11:27 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 06:12:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0592d0cdc43c6928f220ac379f76260e7e31c019
Cr-Commit-Position: refs/heads/master@{#417205}

Powered by Google App Engine
This is Rietveld 408576698