third_party/WebKit/Source/core/dom/ContainerNode.h - Issue 2317573003: Introduce ContainerNode::insertNodeVector() to share code in insertBefore(), appendChild(), and rep…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ContainerNode.h

Issue 2317573003: Introduce ContainerNode::insertNodeVector() to share code in insertBefore(), appendChild(), and rep… (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ContainerNode.h

diff --git a/third_party/WebKit/Source/core/dom/ContainerNode.h b/third_party/WebKit/Source/core/dom/ContainerNode.h

index 4bdf9f285d06f4d042955ce0a0ac08b9d9d68b3f..faa36d2aa1ee05ecc43dadfcd63cba13b497df7f 100644

--- a/third_party/WebKit/Source/core/dom/ContainerNode.h

+++ b/third_party/WebKit/Source/core/dom/ContainerNode.h

@@ -242,7 +242,10 @@ private:

NodeListsNodeData& ensureNodeLists();

void removeBetween(Node* previousChild, Node* nextChild, Node& oldChild);

- void insertBeforeCommon(Node& nextChild, Node& oldChild);

+ void insertNodeVector(const NodeVector&, Node* next, bool (ContainerNode::*mutator)(Node& child, Node* next));

+ bool insertBeforeCommonWithAdoption(Node& newChild, Node* nextChild);

+ bool appendChildCommonWithAdoption(Node& newChild, Node* ignored);

+ void insertBeforeCommon(Node& nextChild, Node& newChild);

void appendChildCommon(Node& child);

void updateTreeAfterInsertion(Node& child);

void willRemoveChildren();