Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Side by Side Diff: third_party/WebKit/Source/core/dom/ContainerNode.h

Issue 2317573003: Introduce ContainerNode::insertNodeVector() to share code in insertBefore(), appendChild(), and rep… (Closed)
Patch Set: Update a copied comment; "this" -> "container" Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011, 2013 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011, 2013 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 template <typename Collection> Collection* ensureCachedCollection(Collection Type, const AtomicString& name); 235 template <typename Collection> Collection* ensureCachedCollection(Collection Type, const AtomicString& name);
236 template <typename Collection> Collection* ensureCachedCollection(Collection Type, const AtomicString& namespaceURI, const AtomicString& localName); 236 template <typename Collection> Collection* ensureCachedCollection(Collection Type, const AtomicString& namespaceURI, const AtomicString& localName);
237 template <typename Collection> Collection* cachedCollection(CollectionType); 237 template <typename Collection> Collection* cachedCollection(CollectionType);
238 238
239 private: 239 private:
240 bool isContainerNode() const = delete; // This will catch anyone doing an un necessary check. 240 bool isContainerNode() const = delete; // This will catch anyone doing an un necessary check.
241 bool isTextNode() const = delete; // This will catch anyone doing an unneces sary check. 241 bool isTextNode() const = delete; // This will catch anyone doing an unneces sary check.
242 242
243 NodeListsNodeData& ensureNodeLists(); 243 NodeListsNodeData& ensureNodeLists();
244 void removeBetween(Node* previousChild, Node* nextChild, Node& oldChild); 244 void removeBetween(Node* previousChild, Node* nextChild, Node& oldChild);
245 void insertBeforeCommon(Node& nextChild, Node& oldChild); 245 template <typename Functor> void insertNodeVector(const NodeVector&, Node* n ext, const Functor&);
246 class AdoptAndInsertBefore;
247 class AdoptAndAppendChild;
248 friend class AdoptAndInsertBefore;
249 friend class AdoptAndAppendChild;
250 void insertBeforeCommon(Node& nextChild, Node& newChild);
246 void appendChildCommon(Node& child); 251 void appendChildCommon(Node& child);
247 void updateTreeAfterInsertion(Node& child); 252 void updateTreeAfterInsertion(Node& child);
248 void willRemoveChildren(); 253 void willRemoveChildren();
249 void willRemoveChild(Node& child); 254 void willRemoveChild(Node& child);
250 void removeDetachedChildrenInContainer(ContainerNode&); 255 void removeDetachedChildrenInContainer(ContainerNode&);
251 void addChildNodesToDeletionQueue(Node*&, Node*&, ContainerNode&); 256 void addChildNodesToDeletionQueue(Node*&, Node*&, ContainerNode&);
252 257
253 void notifyNodeInserted(Node&, ChildrenChangeSource = ChildrenChangeSourceAP I); 258 void notifyNodeInserted(Node&, ChildrenChangeSource = ChildrenChangeSourceAP I);
254 void notifyNodeInsertedInternal(Node&, NodeVector& postInsertionNotification Targets); 259 void notifyNodeInsertedInternal(Node&, NodeVector& postInsertionNotification Targets);
255 void notifyNodeRemoved(Node&); 260 void notifyNodeRemoved(Node&);
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 inline void getChildNodes(ContainerNode& node, NodeVector& nodes) 351 inline void getChildNodes(ContainerNode& node, NodeVector& nodes)
347 { 352 {
348 DCHECK(!nodes.size()); 353 DCHECK(!nodes.size());
349 for (Node* child = node.firstChild(); child; child = child->nextSibling()) 354 for (Node* child = node.firstChild(); child; child = child->nextSibling())
350 nodes.append(child); 355 nodes.append(child);
351 } 356 }
352 357
353 } // namespace blink 358 } // namespace blink
354 359
355 #endif // ContainerNode_h 360 #endif // ContainerNode_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698