Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: chromeos/ime/fake_xkeyboard.h

Issue 231753002: Fixing caps lock problems under ChromeOS where the tray does not properly follow the real caps lock… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_IME_FAKE_XKEYBOARD_H_ 5 #ifndef CHROMEOS_IME_FAKE_XKEYBOARD_H_
6 #define CHROMEOS_IME_FAKE_XKEYBOARD_H_ 6 #define CHROMEOS_IME_FAKE_XKEYBOARD_H_
7 7
8 #include "chromeos/ime/xkeyboard.h" 8 #include "chromeos/ime/xkeyboard.h"
9 9
10 #include <string> 10 #include <string>
11 11
12 #include "base/compiler_specific.h" 12 #include "base/compiler_specific.h"
13 #include "chromeos/chromeos_export.h" 13 #include "chromeos/chromeos_export.h"
14 14
15 namespace chromeos { 15 namespace chromeos {
16 namespace input_method { 16 namespace input_method {
17 17
18 class CHROMEOS_EXPORT FakeXKeyboard : public XKeyboard { 18 class CHROMEOS_EXPORT FakeXKeyboard : public XKeyboard {
19 public: 19 public:
20 FakeXKeyboard(); 20 FakeXKeyboard();
21 virtual ~FakeXKeyboard() {} 21 virtual ~FakeXKeyboard() {}
22 22
23 virtual void AddObserver(Observer* observer) OVERRIDE;
24 virtual void RemoveObserver(Observer* observer) OVERRIDE;
25
Daniel Erat 2014/04/09 20:27:00 nit: remove blank line between these overridden me
Mr4D (OOO till 08-26) 2014/04/09 23:27:02 Done.
23 virtual bool SetCurrentKeyboardLayoutByName(const std::string& layout_name) 26 virtual bool SetCurrentKeyboardLayoutByName(const std::string& layout_name)
24 OVERRIDE; 27 OVERRIDE;
25 virtual bool ReapplyCurrentKeyboardLayout() OVERRIDE; 28 virtual bool ReapplyCurrentKeyboardLayout() OVERRIDE;
26 virtual void ReapplyCurrentModifierLockStatus() OVERRIDE; 29 virtual void ReapplyCurrentModifierLockStatus() OVERRIDE;
27 virtual void DisableNumLock() OVERRIDE; 30 virtual void DisableNumLock() OVERRIDE;
28 virtual void SetCapsLockEnabled(bool enable_caps_lock) OVERRIDE; 31 virtual void SetCapsLockEnabled(bool enable_caps_lock) OVERRIDE;
29 virtual bool CapsLockIsEnabled() OVERRIDE; 32 virtual bool CapsLockIsEnabled() OVERRIDE;
30 virtual bool IsISOLevel5ShiftAvailable() const OVERRIDE; 33 virtual bool IsISOLevel5ShiftAvailable() const OVERRIDE;
31 virtual bool IsAltGrAvailable() const OVERRIDE; 34 virtual bool IsAltGrAvailable() const OVERRIDE;
32 virtual bool SetAutoRepeatEnabled(bool enabled) OVERRIDE; 35 virtual bool SetAutoRepeatEnabled(bool enabled) OVERRIDE;
33 virtual bool SetAutoRepeatRate(const AutoRepeatRate& rate) OVERRIDE; 36 virtual bool SetAutoRepeatRate(const AutoRepeatRate& rate) OVERRIDE;
34 37
35 int set_current_keyboard_layout_by_name_count_; 38 int set_current_keyboard_layout_by_name_count_;
36 std::string last_layout_; 39 std::string last_layout_;
37 bool caps_lock_is_enabled_; 40 bool caps_lock_is_enabled_;
38 bool auto_repeat_is_enabled_; 41 bool auto_repeat_is_enabled_;
39 AutoRepeatRate last_auto_repeat_rate_; 42 AutoRepeatRate last_auto_repeat_rate_;
40 // TODO(yusukes): Add more variables for counting the numbers of the API calls 43 // TODO(yusukes): Add more variables for counting the numbers of the API calls
41 44
42 private: 45 private:
43 DISALLOW_COPY_AND_ASSIGN(FakeXKeyboard); 46 DISALLOW_COPY_AND_ASSIGN(FakeXKeyboard);
44 }; 47 };
45 48
46 } // namespace input_method 49 } // namespace input_method
47 } // namespace chromeos 50 } // namespace chromeos
48 51
49 #endif // CHROMEOS_IME_FAKE_XKEYBOARD_H_ 52 #endif // CHROMEOS_IME_FAKE_XKEYBOARD_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698