Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Issue 2317523003: [Merge-M54] arc: Don't sync app list change caused by Arc opt out. (Closed)

Created:
4 years, 3 months ago by khmel
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Merge-M54] arc: Dont sync app list change caused by Arc opt out. Arc Opt out was recently changed and it is now local change. This causes the problem with syncing app list info because Arc apps are removed from local app list model, shelf and these changes are sent to sync. As result, if user runs another Arc device, Arc apps there will be removed from app list and pin. Solution is not to sync changes, caused by Arc opt out. TEST=Manually on device, opt out Arc on one device and Arc apps are not removed from shelf and app list on another running device. Re-enable Arc again and Arc apps are restrored at the same positions in shelf and App list. TEST=Extended and updated unit_tests BUG=b/31163918 BUG=642864 TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2295343002 Cr-Commit-Position: refs/heads/master@{#416043} (cherry picked from commit c9726f4e10331b7c91542b3e35b22a2c483fd758)

Patch Set 1 #

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317523003/1
4 years, 3 months ago (2016-09-06 22:04:22 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 22:50:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698