Add support of vrdisplayconnect and vrdisplaydisconnect event

Add support of vrdisplayconnect and vrdisplaydisconnect event

This patch adds vrdisplayconnect and vrdisplaydisconnect event support
of google vr sdk for android. It defines 'connect' status as
nativeContext is available and defines 'disconnect' status as
nativeContext is unavailable.

Note that connect event may dispatch before user get vr devices
because devices in connection status could already deliever user some device
info and user could use this event to do some preparing work.

BUG=389343
R=bajones@chromium.org, kenrd@chromium.org, ochang@chromium.org

Committed: https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823
Cr-Commit-Position: refs/heads/master@{#419392}

[shaobo.yan, 2016-09-06 00:52:15]

Description was changed from

==========
Add support of vrdisplayconnect and vrdisplaydisconnect event

This patch adds vrdisplayconnect and vrdisplaydisconnect event support
of google vr sdk for android. It defines 'connect' status as
nativeContext is available and defines 'disconnect' status as
nativeContext is unavailable.

Note that connect event may dispatch before user get vr devices
because devices in connection status could already deliever user some device
info and user could use this event to do some preparing work.

BUG=389343
R=bajones@chromium.org, kenrd@chromium.org, ochang@chromium.org
==========

to

==========
Add support of vrdisplayconnect and vrdisplaydisconnect event

This patch adds vrdisplayconnect and vrdisplaydisconnect event support
of google vr sdk for android. It defines 'connect' status as
nativeContext is available and defines 'disconnect' status as
nativeContext is unavailable.

Note that connect event may dispatch before user get vr devices
because devices in connection status could already deliever user some device
info and user could use this event to do some preparing work.

BUG=389343
R=bajones@chromium.org, kenrd@chromium.org, ochang@chromium.org
==========

[shaobo.yan, 2016-09-06 00:52:15]

shaobo.yan@intel.com changed reviewers:
+ bshe@chromium.org, klausw@chromium.org, mthiesse@chromium.org

[shaobo.yan, 2016-09-06 00:56:22]

The CQ bit was checked by shaobo.yan@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 00:56:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 00:56:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 00:56:31]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bajones, 2016-09-06 23:25:46]

Doesn't look bad. A few comments about changes I'd like to see. (I know this is
largely based on my own code, so I'm mostly complaining about my design choices.
:) Thanks for your patience.)

https://codereview.chromium.org/2317483002/diff/20001/device/vr/vr_device.h
File device/vr/vr_device.h (right):

https://codereview.chromium.org/2317483002/diff/20001/device/vr/vr_device.h#n...
device/vr/vr_device.h:39: virtual void PollEvents() = 0;
As I'm looking through this code it occurs to me that we'll probably only be
firing events like this during PollEvents. For now lets pass the
VRClientDispatcher into this function rather than storing it as a member on the
VRDevice/VRDeviceProvider.

https://codereview.chromium.org/2317483002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/vr/NavigatorVR.cpp (right):

https://codereview.chromium.org/2317483002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:153: void
NavigatorVR::fireVREvent(VRDisplayEvent* event)
Lets have this function call m_frame->localDOMWindow()->enqueueWindowEvent() as
with fireVRDisplayPresentChange above. Then we don't need most of the event
handling changes in this file.

[mthiesse, 2016-09-06 23:39:25]

https://codereview.chromium.org/2317483002/diff/20001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device.cc (right):

https://codereview.chromium.org/2317483002/diff/20001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device.cc:140: // the
nit: fix comment formatting.

[bajones, 2016-09-06 23:57:26]

https://codereview.chromium.org/2317483002/diff/20001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device.cc (right):

https://codereview.chromium.org/2317483002/diff/20001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device.cc:145: void GvrDevice::PollEvents() {
Sorry, I'm also realizing that this is a signal that is probably better handled
in GvrDeviceProvider::OnGvrApiInitialized and
GvrDeviceProvider::OnGvrApiShutdown (which will be renamed once
https://codereview.chromium.org/2309523003/ lands.) Those two functions should
act as very clear connected/disconnected signals for the purposes of GVR, making
a polling loop unnecessary.

[shaobo.yan, 2016-09-07 00:49:19]

https://codereview.chromium.org/2317483002/diff/20001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device.cc (right):

https://codereview.chromium.org/2317483002/diff/20001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device.cc:145: void GvrDevice::PollEvents() {
On 2016/09/06 23:57:26, bajones wrote:
> Sorry, I'm also realizing that this is a signal that is probably better
handled
> in GvrDeviceProvider::OnGvrApiInitialized and
> GvrDeviceProvider::OnGvrApiShutdown (which will be renamed once
> https://codereview.chromium.org/2309523003/ lands.) Those two functions should
> act as very clear connected/disconnected signals for the purposes of GVR,
making
> a polling loop unnecessary.

Hi, brandon, thx for reviewing! I agree that OnGvrApiInitialized and
OnGvrApiShutdown is the place to handle connected/disconnected signals. But What
I concerned is how about the situation of reconnection? if we handle connected
signal in OnGvrApiInitialized, does it means that every time reconnection
happened, an old device object will be discarded and a new device object will be
created?

[shaobo.yan, 2016-09-07 02:45:50]

https://codereview.chromium.org/2317483002/diff/20001/device/vr/vr_device.h
File device/vr/vr_device.h (right):

https://codereview.chromium.org/2317483002/diff/20001/device/vr/vr_device.h#n...
device/vr/vr_device.h:39: virtual void PollEvents() = 0;
On 2016/09/06 23:25:46, bajones wrote:
> As I'm looking through this code it occurs to me that we'll probably only be
> firing events like this during PollEvents. For now lets pass the
> VRClientDispatcher into this function rather than storing it as a member on
the
> VRDevice/VRDeviceProvider.
I'll move client_ from VRDevice to VRDeviceProvider to process
connect/disconnect signal.

[shaobo.yan, 2016-09-08 03:46:26]

The CQ bit was checked by shaobo.yan@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 03:46:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 03:46:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 03:46:51]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[shaobo.yan, 2016-09-08 07:26:35]

On 2016/09/07 00:49:19, shaobo.yan wrote:
>
https://codereview.chromium.org/2317483002/diff/20001/device/vr/android/gvr/g...
> File device/vr/android/gvr/gvr_device.cc (right):
> 
>
https://codereview.chromium.org/2317483002/diff/20001/device/vr/android/gvr/g...
> device/vr/android/gvr/gvr_device.cc:145: void GvrDevice::PollEvents() {
> On 2016/09/06 23:57:26, bajones wrote:
> > Sorry, I'm also realizing that this is a signal that is probably better
> handled
> > in GvrDeviceProvider::OnGvrApiInitialized and
> > GvrDeviceProvider::OnGvrApiShutdown (which will be renamed once
> > https://codereview.chromium.org/2309523003/ lands.) Those two functions
should
> > act as very clear connected/disconnected signals for the purposes of GVR,
> making
> > a polling loop unnecessary.
> 
> Hi, Brandon, thx for reviewing! I agree that OnGvrApiInitialized and
> OnGvrApiShutdown is the place to handle connected/disconnected signals. But
What
> I concerned is how about the situation of reconnection? if we handle connected
> signal in OnGvrApiInitialized, does it means that every time reconnection
> happened, an old device object will be discarded and a new device object will
be
> created?

Hi Brandon, the latest patch set uses OnGvrApiInitialized and OnGvrApiShutdown
as the device status updated signal, but the event will be fired when the
pollEvent is invoked.
Please correct me if I misunderstand something, it seems that using pollEvent to
query device status and fire event could also be used to enable HTC Vive or
Oculus.
And fire event in this way could remove VRClientDispatcher object which stored
in VRDeviceProvider/VRDevice as you mentioned. 
Thx.

[shaobo.yan, 2016-09-09 00:34:26]

ping bajones@ and mthiesse@, PTAL.

[bajones, 2016-09-09 00:35:34]

On 2016/09/09 00:34:26, shaobo.yan wrote:
> ping bajones@ and mthiesse@, PTAL.

Apologies, I've been swamped for the past couple of days. I'll review the latest
tonight.

[shaobo.yan, 2016-09-09 00:38:45]

On 2016/09/09 00:35:34, bajones wrote:
> On 2016/09/09 00:34:26, shaobo.yan wrote:
> > ping bajones@ and mthiesse@, PTAL.
> 
> Apologies, I've been swamped for the past couple of days. I'll review the
latest
> tonight.

Welcome. And I've seen lots of patches and the latest update of WebVR spec from
your :P

[bajones, 2016-09-09 05:53:00]

Definitely feeling better. Two more bits of feedback and I think we'll be good.

https://codereview.chromium.org/2317483002/diff/40001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device.cc (right):

https://codereview.chromium.org/2317483002/diff/40001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device.cc:172:
client->OnDeviceConnectionStatusChanged(this, isConnected_);
Let's call this in UpdateConnectionStatus and avoid introducing the event
polling loop in this patch.

https://codereview.chromium.org/2317483002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/vr/NavigatorVR.h (right):

https://codereview.chromium.org/2317483002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/vr/NavigatorVR.h:60:
Member<AsyncMethodRunner<NavigatorVR>> m_dispatchOneEventRunner;
Looks like the only change actually needed in this file is the addition of
fireVREvent. Please remove the rest.

[mthiesse, 2016-09-10 20:58:34]

A few style nits.

https://codereview.chromium.org/2317483002/diff/40001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device.h (right):

https://codereview.chromium.org/2317483002/diff/40001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device.h:33: // Gvr connection/disconnection Status
Handler
Style nit: Comments should end with a period.

https://codereview.chromium.org/2317483002/diff/40001/device/vr/vr_device_man...
File device/vr/vr_device_manager.h (right):

https://codereview.chromium.org/2317483002/diff/40001/device/vr/vr_device_man...
device/vr/vr_device_manager.h:45: bool isConnected) override;
s/isConnected/is_connected here and in .cc

[shaobo.yan, 2016-09-12 00:42:35]

Thx for reviwing and apologize for response late due to personal network issue
(my VPN has expired this weekend...) And PTAL bajones@ and mthiesse@

[bajones, 2016-09-12 01:36:16]

No worries, and thanks for sticking with this! A few more comments for you, and
then I think we're done.

You'll need an owners review for the .mojom file, by the way. I can't provide
that. Request it from someone in this file:
https://cs.chromium.org/chromium/src/ipc/SECURITY_OWNERS

https://codereview.chromium.org/2317483002/diff/80001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device.h (right):

https://codereview.chromium.org/2317483002/diff/80001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device.h:37: bool isConnectionStatusChanged_;
These values are no longer used and the PollEvents call is empty. With this
latest update we don't need any changes to gvr_device.h/cc, so let's just revert
those to files.

https://codereview.chromium.org/2317483002/diff/80001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device_provider.cc (right):

https://codereview.chromium.org/2317483002/diff/80001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device_provider.cc:107: // fire a
vrdisplaydisconnected event.
Happily this comment is no longer accurate! Lets remove it.

https://codereview.chromium.org/2317483002/diff/80001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device_provider.h (right):

https://codereview.chromium.org/2317483002/diff/80001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device_provider.h:32: void PollEvents() override;
This doesn't do anything anymore, so lets leave it out.

https://codereview.chromium.org/2317483002/diff/80001/device/vr/vr_device.h
File device/vr/vr_device.h (right):

https://codereview.chromium.org/2317483002/diff/80001/device/vr/vr_device.h#n...
device/vr/vr_device.h:38: virtual void PollEvents() = 0;
This is another file who's changes are no longer necessary.

[shaobo.yan, 2016-09-12 01:58:01]

shaobo.yan@intel.com changed reviewers:
+ dcheng@chromium.org

[shaobo.yan, 2016-09-12 01:59:02]

bajones@ all comments done! and dcheng@ PTAL

https://codereview.chromium.org/2317483002/diff/80001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device.h (right):

https://codereview.chromium.org/2317483002/diff/80001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device.h:37: bool isConnectionStatusChanged_;
On 2016/09/12 01:36:15, bajones wrote:
> These values are no longer used and the PollEvents call is empty. With this
> latest update we don't need any changes to gvr_device.h/cc, so let's just
revert
> those to files.

Done.

https://codereview.chromium.org/2317483002/diff/80001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device_provider.cc (right):

https://codereview.chromium.org/2317483002/diff/80001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device_provider.cc:107: // fire a
vrdisplaydisconnected event.
On 2016/09/12 01:36:15, bajones wrote:
> Happily this comment is no longer accurate! Lets remove it.

Done.

https://codereview.chromium.org/2317483002/diff/80001/device/vr/android/gvr/g...
File device/vr/android/gvr/gvr_device_provider.h (right):

https://codereview.chromium.org/2317483002/diff/80001/device/vr/android/gvr/g...
device/vr/android/gvr/gvr_device_provider.h:32: void PollEvents() override;
On 2016/09/12 01:36:15, bajones wrote:
> This doesn't do anything anymore, so lets leave it out.

Done.

https://codereview.chromium.org/2317483002/diff/80001/device/vr/vr_device.h
File device/vr/vr_device.h (right):

https://codereview.chromium.org/2317483002/diff/80001/device/vr/vr_device.h#n...
device/vr/vr_device.h:38: virtual void PollEvents() = 0;
On 2016/09/12 01:36:15, bajones wrote:
> This is another file who's changes are no longer necessary.

Done.

[bajones, 2016-09-12 02:33:14]

LGTM! Thanks!

[shaobo.yan, 2016-09-12 02:34:22]

The CQ bit was checked by shaobo.yan@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 02:34:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 03:05:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 03:05:01]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[shaobo.yan, 2016-09-12 07:27:31]

The CQ bit was checked by shaobo.yan@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 07:27:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 08:22:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 08:22:36]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[shaobo.yan, 2016-09-12 08:43:48]

The CQ bit was checked by shaobo.yan@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 08:44:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 09:38:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 09:38:46]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[shaobo.yan, 2016-09-13 00:51:54]

The CQ bit was checked by shaobo.yan@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 00:52:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shaobo.yan, 2016-09-13 02:10:54]

shaobo.yan@intel.com changed reviewers:
+ jln@chromium.org, kenrb@chromium.org

[shaobo.yan, 2016-09-13 02:11:41]

dcheng@, jln@ and kenrb@ PTAL the mojom file modification

[commit-bot: I haz the power, 2016-09-13 02:36:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 02:36:21]

Dry run: This issue passed the CQ dry run.

[kenrb, 2016-09-13 16:30:38]

mojom lgtm

[shaobo.yan, 2016-09-18 00:17:05]

The CQ bit was checked by shaobo.yan@intel.com

[shaobo.yan, 2016-09-18 00:17:05]

The patchset sent to the CQ was uploaded after l-g-t-m from bajones@chromium.org
Link to the patchset: https://codereview.chromium.org/2317483002/#ps150001
(title: "Remove unused variable")

[commit-bot: I haz the power, 2016-09-18 00:17:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-18 00:19:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-18 00:19:19]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[shaobo.yan, 2016-09-18 00:51:07]

The CQ bit was checked by shaobo.yan@intel.com

[shaobo.yan, 2016-09-18 00:51:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
bajones@chromium.org, kenrb@chromium.org
Link to the patchset: https://codereview.chromium.org/2317483002/#ps170001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-18 00:51:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-18 01:16:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-18 01:16:30]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[shaobo.yan, 2016-09-18 01:24:07]

The CQ bit was checked by shaobo.yan@intel.com

[shaobo.yan, 2016-09-18 01:24:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
bajones@chromium.org, kenrb@chromium.org
Link to the patchset: https://codereview.chromium.org/2317483002/#ps190001
(title: "fix missing brace")

[commit-bot: I haz the power, 2016-09-18 01:24:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-18 03:12:52]

Description was changed from

==========
Add support of vrdisplayconnect and vrdisplaydisconnect event

This patch adds vrdisplayconnect and vrdisplaydisconnect event support
of google vr sdk for android. It defines 'connect' status as
nativeContext is available and defines 'disconnect' status as
nativeContext is unavailable.

Note that connect event may dispatch before user get vr devices
because devices in connection status could already deliever user some device
info and user could use this event to do some preparing work.

BUG=389343
R=bajones@chromium.org, kenrd@chromium.org, ochang@chromium.org
==========

to

==========
Add support of vrdisplayconnect and vrdisplaydisconnect event

This patch adds vrdisplayconnect and vrdisplaydisconnect event support
of google vr sdk for android. It defines 'connect' status as
nativeContext is available and defines 'disconnect' status as
nativeContext is unavailable.

Note that connect event may dispatch before user get vr devices
because devices in connection status could already deliever user some device
info and user could use this event to do some preparing work.

BUG=389343
R=bajones@chromium.org, kenrd@chromium.org, ochang@chromium.org
==========

[commit-bot: I haz the power, 2016-09-18 03:12:53]

Committed patchset #11 (id:190001)

[commit-bot: I haz the power, 2016-09-18 03:15:38]

Description was changed from

==========
Add support of vrdisplayconnect and vrdisplaydisconnect event

This patch adds vrdisplayconnect and vrdisplaydisconnect event support
of google vr sdk for android. It defines 'connect' status as
nativeContext is available and defines 'disconnect' status as
nativeContext is unavailable.

Note that connect event may dispatch before user get vr devices
because devices in connection status could already deliever user some device
info and user could use this event to do some preparing work.

BUG=389343
R=bajones@chromium.org, kenrd@chromium.org, ochang@chromium.org
==========

to

==========
Add support of vrdisplayconnect and vrdisplaydisconnect event

This patch adds vrdisplayconnect and vrdisplaydisconnect event support
of google vr sdk for android. It defines 'connect' status as
nativeContext is available and defines 'disconnect' status as
nativeContext is unavailable.

Note that connect event may dispatch before user get vr devices
because devices in connection status could already deliever user some device
info and user could use this event to do some preparing work.

BUG=389343
R=bajones@chromium.org, kenrd@chromium.org, ochang@chromium.org

Committed: https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823
Cr-Commit-Position: refs/heads/master@{#419392}
==========

[commit-bot: I haz the power, 2016-09-18 03:15:39]

Patchset 11 (id:??) landed as
https://crrev.com/66ce5b08f2af95f149303ad716119db190a52823
Cr-Commit-Position: refs/heads/master@{#419392}