Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2317473002: Revert of Roll typ to v0.9.7. (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll typ to v0.9.7. (patchset #1 id:1 of https://codereview.chromium.org/2289303002/ ) Reason for revert: Let's see if reverting this helps w/ crbug.com/643320. Original issue's description: > Roll typ to v0.9.7. > > This picks up a change that will help address flaky telemetry failures. > > This includes the following changes (v0.9.5..v0.9.7): > > 79fe79db Change typ's interpretation of a test that first fails > and is then skipped. > 101acd31 Bump version to 0.9.6, clean up Python 3 failures > 2f8787b8 rework run script to remove python3 log > d5023636 rework sharding tests > > TBR=rnephew@chromium.org, nednguyen@google.com > BUG=618330 > > Committed: https://crrev.com/71c9ade4e91e16846779311f1ae800ed550c8b69 > Cr-Commit-Position: refs/heads/master@{#415392} TBR=nednguyen@google.com,rnephew@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=618330, 643320 Committed: https://crrev.com/1023620c13385de9fcea55ec35f66dc22b454ff8 Cr-Commit-Position: refs/heads/master@{#416573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -123 lines) Patch
M third_party/typ/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/typ/codereview.settings View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/typ/run View 5 chunks +26 lines, -10 lines 0 comments Download
M third_party/typ/typ/json_results.py View 3 chunks +5 lines, -12 lines 0 comments Download
M third_party/typ/typ/runner.py View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/typ/typ/tests/main_test.py View 10 chunks +138 lines, -87 lines 0 comments Download
M third_party/typ/typ/tests/pool_test.py View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/typ/typ/version.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Dirk Pranke
Created Revert of Roll typ to v0.9.7.
4 years, 3 months ago (2016-09-06 00:29:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317473002/1
4 years, 3 months ago (2016-09-06 00:29:59 UTC) #6
nednguyen(REVIEW IN OTHER ACC)
lgtm
4 years, 3 months ago (2016-09-06 01:19:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 01:52:05 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1023620c13385de9fcea55ec35f66dc22b454ff8 Cr-Commit-Position: refs/heads/master@{#416573}
4 years, 3 months ago (2016-09-06 01:55:36 UTC) #12
nednguyen
4 years, 3 months ago (2016-09-08 21:16:25 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2328753002/ by nednguyen@google.com.

The reason for reverting is: This is probably not the root cause of
crbug.com/643320.

Powered by Google App Engine
This is Rietveld 408576698