Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 231743004: Mojo's JS codec missing 16-bit read/write operations. (Closed)

Created:
6 years, 8 months ago by Tom Sepez
Modified:
6 years, 8 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo's JS codec missing 16-bit read/write operations. I stumbled across this while trying to pass int16's into javascript. This looks like a simple omission. R=viettrungluu@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M mojo/public/js/bindings/codec.js View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tom Sepez
Trung, please review. Thanks!
6 years, 8 months ago (2014-04-09 23:12:36 UTC) #1
viettrungluu
Thanks for the fix. LGTM.
6 years, 8 months ago (2014-04-09 23:46:29 UTC) #2
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 8 months ago (2014-04-09 23:47:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/231743004/1
6 years, 8 months ago (2014-04-09 23:49:05 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 05:01:57 UTC) #5
Message was sent while issue was closed.
Change committed as 262920

Powered by Google App Engine
This is Rietveld 408576698