Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2317403004: [MD settings] align toggle buttons in rtl (Closed)

Created:
4 years, 3 months ago by dschuyler
Modified:
4 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] align toggle buttons in rtl This CL adjusts the paper toggle components to that they layout well in ltr and rtl. BUG=642642 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e97f5450b97c632730dc2b255599568c4198c5e8 Cr-Commit-Position: refs/heads/master@{#417981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/settings/settings_vars_css.html View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
dschuyler
4 years, 3 months ago (2016-09-08 19:23:04 UTC) #5
stevenjb
lgtm
4 years, 3 months ago (2016-09-12 16:33:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317403004/1
4 years, 3 months ago (2016-09-12 17:08:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 18:36:17 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 18:38:38 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e97f5450b97c632730dc2b255599568c4198c5e8
Cr-Commit-Position: refs/heads/master@{#417981}

Powered by Google App Engine
This is Rietveld 408576698