Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2317373004: Clean up target_os=llvm now that it does nothing. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up target_os=llvm now that it does nothing. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317373004 Committed: https://skia.googlesource.com/skia/+/e19c179281967dd071f3fea6dc010a676bea799d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -53 lines) Patch
M DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M infra/bots/recipe_modules/core/api.py View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-Arm7-Debug-Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-Arm7-Release-iOS.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-mipsel-Debug-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-x86_64-Debug-CommandBuffer.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-x86_64-Release-CMake.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-x86_64-Release-GN.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-Clang-arm64-Release-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-Clang-x86_64-Debug-ASAN.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-Clang-x86_64-Debug-GN.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-Arm7-Debug-Android_FrameworkDefs.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-Arm7-Debug-Android_NoNeon.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-Arm7-Release-Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-Arm7-Release-Android_Vulkan.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86-Debug.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Debug-GN.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Debug-MSAN.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-ANGLE.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-CMake.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-Fast.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-Mesa.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-PDFium.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-Shared.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-Valgrind.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Debug.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Debug-Exceptions.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GDI.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86_64-Release-Vulkan.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/big_issue_number.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/failed_compile.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/recipe_with_gerrit_patch.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/win_retry_failed_compile.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_CPU_BENCH_10k_SKPs.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_DM_100k_SKPs.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_DM_10k_SKPs.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_DM_10k_SKPs_Trybot.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_DM_1m_SKPs.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_DM_1m_SKPs_2slaves_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_DM_1m_SKPs_slave3_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_GPU_BENCH_10k_SKPs.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_GPU_BENCH_1k_SKPs.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_IMG_DECODE_100k_SKPs.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_IMG_DECODE_10k_SKPs.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_IMG_DECODE_10k_SKPs_Trybot.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
4 years, 3 months ago (2016-09-08 15:56:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317373004/1
4 years, 3 months ago (2016-09-08 15:56:46 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-08 15:56:47 UTC) #6
borenet
LGTM
4 years, 3 months ago (2016-09-08 16:01:46 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 16:19:05 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e19c179281967dd071f3fea6dc010a676bea799d

Powered by Google App Engine
This is Rietveld 408576698