Fix use-after-free in ~GpuProcessTransportFactory

Fix use-after-free in ~GpuProcessTransportFactory

Previously, this used to leak, but now that it gets destroyed during
shutdown, this DCHECK turns into a security issue.  Work around this
by clearing data in the correct order even if it should already be
cleared prior to destruction.

R=danakj@chromium.org
BUG=645075
Committed: https://crrev.com/15ca791b6abd8cabac85497ea6290b276cb38152
Cr-Commit-Position: refs/heads/master@{#417620}

[enne (OOO), 2016-09-08 23:03:13]

Enjoy this bandaid <_<

Alternatively, newly minted windows mains could repro this locally to understand
why this would DCHECK.  Just sayin'.

[danakj, 2016-09-08 23:13:41]

LGTM

[enne (OOO), 2016-09-08 23:14:00]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:14:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 23:22:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:22:07]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[enne (OOO), 2016-09-09 00:19:37]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 00:20:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 01:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 01:03:51]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2016-09-09 17:36:49]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2016-09-09 17:37:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 17:41:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-09 17:44:04]

Description was changed from

==========
Fix use-after-free in ~GpuProcessTransportFactory

Previously, this used to leak, but now that it gets destroyed during
shutdown, this DCHECK turns into a security issue.  Work around this
by clearing data in the correct order even if it should already be
cleared prior to destruction.

R=danakj@chromium.org
BUG=645075
==========

to

==========
Fix use-after-free in ~GpuProcessTransportFactory

Previously, this used to leak, but now that it gets destroyed during
shutdown, this DCHECK turns into a security issue.  Work around this
by clearing data in the correct order even if it should already be
cleared prior to destruction.

R=danakj@chromium.org
BUG=645075

Committed: https://crrev.com/15ca791b6abd8cabac85497ea6290b276cb38152
Cr-Commit-Position: refs/heads/master@{#417620}
==========

[commit-bot: I haz the power, 2016-09-09 17:44:05]

Patchset 2 (id:??) landed as
https://crrev.com/15ca791b6abd8cabac85497ea6290b276cb38152
Cr-Commit-Position: refs/heads/master@{#417620}