Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2317363002: Allow tab model to be selected during merge if current model has no tabs (Closed)

Created:
4 years, 3 months ago by Theresa
Modified:
4 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow tab model to be selected during merge if current model has no tabs On tablets it's possible to end up with a "dummy" tab selected if the EmptyBackgroundView is showing when a merge is triggered and the currently "selected" model has no tabs in it. In this case, do not reset the tab model selection to the model that was selected before the merge. BUG=644707 Committed: https://crrev.com/b7c7b6b79243f0e1bc330e2df22cbfb1bb008a35 Cr-Commit-Position: refs/heads/master@{#417145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Theresa
ptal
4 years, 3 months ago (2016-09-08 00:20:13 UTC) #3
gone
So many fun special cases here. lgtm
4 years, 3 months ago (2016-09-08 00:25:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317363002/1
4 years, 3 months ago (2016-09-08 00:31:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 01:19:14 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 01:21:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7c7b6b79243f0e1bc330e2df22cbfb1bb008a35
Cr-Commit-Position: refs/heads/master@{#417145}

Powered by Google App Engine
This is Rietveld 408576698