Re-land (2): Fix loading accessibility tree for child frame that's already loaded.

Re-land (2): Fix loading accessibility tree for child frame that's already loaded.

Original issue: http://crrev.com/2299673002
Second attempt: http://crrev.com/2299283002

Fix the flakiness by not trying to toggle accessibility off and on between the
two runs of the same page within each test.

Code leftover from the pre-OOPIF days was causing us to exit early from
the RenderAccessibilityImpl constructor for some child frames that were
already loaded. Everything worked fine if accessibility was already enabled
when loading the frame, but if the frame was already loaded and then
accessibility was enabled, this could cause it to fail to create an
accessibility tree.

The code in RenderAccessibilityImpl is no longer needed because now we
have exactly one accessibility tree per frame.

This wasn't caught by tests because we didn't cover both scenarios, we
always enabled accessibility first.

Added two variants of existing tests that load the page first and then
enable accessibility.

BUG=640231
TBR=dtseng@chromium.org

Committed: https://crrev.com/1942f9c21b858d39d748132d4a756f3526445cdb
Cr-Commit-Position: refs/heads/master@{#417194}

[dmazzoni, 2016-09-07 22:26:42]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 22:27:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 00:15:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 00:15:45]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-09-08 05:31:31]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-09-08 05:31:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 05:40:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-08 05:44:35]

Description was changed from

==========
Re-land (2): Fix loading accessibility tree for child frame that's already
loaded.

Original issue: http://crrev.com/2299673002
Second attempt: http://crrev.com/2299283002

Fix the flakiness by not trying to toggle accessibility off and on between the
two runs of the same page within each test.

Code leftover from the pre-OOPIF days was causing us to exit early from
the RenderAccessibilityImpl constructor for some child frames that were
already loaded. Everything worked fine if accessibility was already enabled
when loading the frame, but if the frame was already loaded and then
accessibility was enabled, this could cause it to fail to create an
accessibility tree.

The code in RenderAccessibilityImpl is no longer needed because now we
have exactly one accessibility tree per frame.

This wasn't caught by tests because we didn't cover both scenarios, we
always enabled accessibility first.

Added two variants of existing tests that load the page first and then
enable accessibility.

BUG=640231
TBR=dtseng@chromium.org
==========

to

==========
Re-land (2): Fix loading accessibility tree for child frame that's already
loaded.

Original issue: http://crrev.com/2299673002
Second attempt: http://crrev.com/2299283002

Fix the flakiness by not trying to toggle accessibility off and on between the
two runs of the same page within each test.

Code leftover from the pre-OOPIF days was causing us to exit early from
the RenderAccessibilityImpl constructor for some child frames that were
already loaded. Everything worked fine if accessibility was already enabled
when loading the frame, but if the frame was already loaded and then
accessibility was enabled, this could cause it to fail to create an
accessibility tree.

The code in RenderAccessibilityImpl is no longer needed because now we
have exactly one accessibility tree per frame.

This wasn't caught by tests because we didn't cover both scenarios, we
always enabled accessibility first.

Added two variants of existing tests that load the page first and then
enable accessibility.

BUG=640231
TBR=dtseng@chromium.org

Committed: https://crrev.com/1942f9c21b858d39d748132d4a756f3526445cdb
Cr-Commit-Position: refs/heads/master@{#417194}
==========

[commit-bot: I haz the power, 2016-09-08 05:44:36]

Patchset 1 (id:??) landed as
https://crrev.com/1942f9c21b858d39d748132d4a756f3526445cdb
Cr-Commit-Position: refs/heads/master@{#417194}