Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2317313002: Add git number footer generation to git cl land. (Closed)

Created:
4 years, 3 months ago by tandrii(chromium)
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add git number footer generation to git cl land. This only applies to Rietveld git cl land and only if pending_prefix option isn't enabled. This means that this CL isn't changing existing functionality, hence safe to land. BUG=642493

Patch Set 1 #

Patch Set 2 : wow, there is no test coverage #

Patch Set 3 : Prove there is no test coverage. #

Patch Set 4 : -missing {footers amending + tests} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -1 line) Patch
M git_cl.py View 1 2 3 3 chunks +76 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2322783002 Patch 1

Messages

Total messages: 10 (10 generated)
tandrii(chromium)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-07 22:14:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317313002/20001
4 years, 3 months ago (2016-09-07 22:14:46 UTC) #2
tandrii(chromium)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-07 22:22:55 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317313002/40001
4 years, 3 months ago (2016-09-07 22:23:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-07 22:29:59 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/311f910d649fe010)
4 years, 3 months ago (2016-09-07 22:30:00 UTC) #6
tandrii(chromium)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-09 20:15:08 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317313002/60001
4 years, 3 months ago (2016-09-09 20:15:16 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-09 20:21:05 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 20:21:06 UTC) #10 
Dry run: Try jobs failed on following builders:
  Depot Tools Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/312968bea2d74810)

Powered by Google App Engine
This is Rietveld 408576698