pkg/fixnum/lib/fixnum.dart - Issue 23173002: Added fixnum package docs.

Side by Side Diff: pkg/fixnum/lib/fixnum.dart

Issue 23173002: Added fixnum package docs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Added note on DartVM/dart2js compatibility Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

	5 /**

	6 * This library provides fixed-size integer support.
	justinfagnani 2013/08/14 17:06:51 mention that it contains a 32 bit and 64 signed in mention that it contains a 32 bit and 64 signed int? Kathy Walrath 2013/08/14 17:15:07 Our convention is for the first line to not be a Our convention is for the first line to not be a complete sentence. How about just: Fixed-size integer support. Chris Bracken 2013/08/14 17:45:31 Done. Show quoted text On 2013/08/14 17:06:51, justinfagnani wrote: > mention that it contains a 32 bit and 64 signed int? Done. Chris Bracken 2013/08/14 17:45:31 Done. Show quoted text On 2013/08/14 17:15:07, Kathy Walrath wrote: > Our convention is for the first line to not be a complete sentence. How about > just: > > Fixed-size integer support. Done.
	7 *

	8 * The integer implementations in this library are guaranteed to behave

	9 * identically whether executed on the Dart VM or compiled to JavaScript.

	10 *

	11 * ## Installing ##
	justinfagnani 2013/08/14 17:06:51 Do most libraries include pub install directions i Do most libraries include pub install directions in the library docs? I would think pub instructions should be left at the package level. Kathy Walrath 2013/08/14 17:15:07 Why is there a ## after this header? Why is there a ## after this header? Chris Bracken 2013/08/14 17:45:31 I modelled these off the intl package. I agree tho Show quoted text On 2013/08/14 17:06:51, justinfagnani wrote: > Do most libraries include pub install directions in the library docs? I would > think pub instructions should be left at the package level. I modelled these off the intl package. I agree though, README.md (which I've now added) seems like a better place for this. Thoughts? Chris Bracken 2013/08/14 17:45:31 Done. Show quoted text On 2013/08/14 17:15:07, Kathy Walrath wrote: > Why is there a ## after this header? Done.
	12 *

	13 * Use [pub][] to install this package. Add the following to your `pubspec.yaml`
	Kathy Walrath 2013/08/14 17:15:07 I'm not used to this style of linking. Is there a I'm not used to this style of linking. Is there a reason why you used this style here and the []() style later? I'm inclined to use the []() style. Maybe I should put this in the style guidelines unless there's a good reason not to. Chris Bracken 2013/08/14 17:45:31 Done. Show quoted text On 2013/08/14 17:15:07, Kathy Walrath wrote: > I'm not used to this style of linking. Is there a reason why you used this style > here and the []() style later? > > I'm inclined to use the []() style. Maybe I should put this in the style > guidelines unless there's a good reason not to. Done.
	14 * file.
	Kathy Walrath 2013/08/14 17:15:07 file. -> file: file. -> file: Chris Bracken 2013/08/14 17:45:31 Done. Show quoted text On 2013/08/14 17:15:07, Kathy Walrath wrote: > file. -> file: Done.
	15 *

	16 * dependencies:

	17 * fixnum: any

	18 *

	19 * Then run `pub install`.

	20 *

	21 * For more information, see the

	22 * [fixnum package on pub.dartlang.org]

	23 * (http://pub.dartlang.org/packages/fixnum).

	24 *

	25 * [pub]: http://pub.dartlang.org

	26 */

5 library fixnum;	27 library fixnum;

6	28

7 part 'src/intx.dart';	29 part 'src/intx.dart';

8 part 'src/int32.dart';	30 part 'src/int32.dart';

9 part 'src/int64.dart';	31 part 'src/int64.dart';

OLD	NEW

« no previous file with comments | « no previous file | pkg/fixnum/lib/src/intx.dart » ('j') | pkg/fixnum/lib/src/intx.dart » ('J')