Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2317273002: [WebApk] Reland Update verification keys. (Closed)

Created:
4 years, 3 months ago by hartmanng
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dominickn+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebApk] Reland Update verification keys. This is a reland of https://codereview.chromium.org/2293603002/. Reason for revert: Build fails with: jmake: Could not find class file for /tmp/tmp7BuImL/java/org/chromium/browser/webapps/ChromeWebApkHostSignature.java. Original CL description: > [WebApk] Update verification keys. > > Update keys to latest test keys and also break it out by channel. > > TBR=rsesek@chromium.org,yfriedman@chromium.org > > Committed: https://crrev.com/716cc589da62b7cc48ac0542fe01239808687ec9 > Cr-Commit-Position: refs/heads/master@{#416339} Patchset 1 on https://codereview.chromium.org/2317273002/ is the original landed patch from https://codereview.chromium.org/2293603002/. Patchset 2 contains the fix in the build file. TBR=rsesek@chromium.org,yfriedman@chromium.org,dfalcantara@chromium.org,mdjones@chromium.org Committed: https://crrev.com/61ebeedfd6883e64426d458c22822928deff62fc Cr-Commit-Position: refs/heads/master@{#417062}

Patch Set 1 #

Patch Set 2 : fix build #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -74 lines) Patch
M chrome/android/BUILD.gn View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java View 2 chunks +1 line, -55 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHostSignature.template View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/android/webapk/channel_keys.h View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java View 6 chunks +14 lines, -13 lines 0 comments Download
M chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317273002/60001
4 years, 3 months ago (2016-09-07 20:37:15 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 3 months ago (2016-09-07 21:53:23 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 21:55:12 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/61ebeedfd6883e64426d458c22822928deff62fc
Cr-Commit-Position: refs/heads/master@{#417062}

Powered by Google App Engine
This is Rietveld 408576698