Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1561)

Side by Side Diff: content/browser/dom_storage/dom_storage_task_runner.h

Issue 2317253007: Remove calls to IsRunningSequenceOnCurrentThread() from dom_storage_task_runner.cc (Closed)
Patch Set: CR michaeln #9 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_H_ 5 #ifndef CONTENT_BROWSER_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_H_
6 #define CONTENT_BROWSER_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_H_ 6 #define CONTENT_BROWSER_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/sequence_checker.h"
9 #include "base/sequenced_task_runner.h" 10 #include "base/sequenced_task_runner.h"
10 #include "base/single_thread_task_runner.h" 11 #include "base/single_thread_task_runner.h"
11 #include "base/threading/sequenced_worker_pool.h" 12 #include "base/threading/sequenced_worker_pool.h"
12 #include "base/time/time.h" 13 #include "base/time/time.h"
13 #include "content/common/content_export.h" 14 #include "content/common/content_export.h"
14 15
15 namespace base { 16 namespace base {
16 class SingleThreadTaskRunner; 17 class SingleThreadTaskRunner;
17 } 18 }
18 19
(...skipping 21 matching lines...) Expand all
40 bool PostDelayedTask(const tracked_objects::Location& from_here, 41 bool PostDelayedTask(const tracked_objects::Location& from_here,
41 const base::Closure& task, 42 const base::Closure& task,
42 base::TimeDelta delay) override = 0; 43 base::TimeDelta delay) override = 0;
43 44
44 // Posts a shutdown blocking task to |sequence_id|. 45 // Posts a shutdown blocking task to |sequence_id|.
45 virtual bool PostShutdownBlockingTask( 46 virtual bool PostShutdownBlockingTask(
46 const tracked_objects::Location& from_here, 47 const tracked_objects::Location& from_here,
47 SequenceID sequence_id, 48 SequenceID sequence_id,
48 const base::Closure& task) = 0; 49 const base::Closure& task) = 0;
49 50
50 // The TaskRunner override returns true if the current thread is running 51 virtual void AssertIsRunningOnPrimarySequence() const = 0;
51 // on the primary sequence. 52 virtual void AssertIsRunningOnCommitSequence() const = 0;
52 bool RunsTasksOnCurrentThread() const override;
53
54 // Returns true if the current thread is running on the given |sequence_id|.
55 virtual bool IsRunningOnSequence(SequenceID sequence_id) const = 0;
56 bool IsRunningOnPrimarySequence() const {
57 return IsRunningOnSequence(PRIMARY_SEQUENCE);
58 }
59 bool IsRunningOnCommitSequence() const {
60 return IsRunningOnSequence(COMMIT_SEQUENCE);
61 }
62 53
63 virtual scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner( 54 virtual scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner(
64 SequenceID sequence_id) = 0; 55 SequenceID sequence_id) = 0;
65 56
66 protected: 57 protected:
67 ~DOMStorageTaskRunner() override {} 58 ~DOMStorageTaskRunner() override {}
68 }; 59 };
69 60
70 // A derived class used in chromium that utilizes a SequenceWorkerPool 61 // A derived class used in chromium that utilizes a SequenceWorkerPool
71 // under dom_storage specific SequenceTokens. The |delayed_task_loop| 62 // under dom_storage specific SequenceTokens. The |delayed_task_loop|
72 // is used to delay scheduling on the worker pool. 63 // is used to delay scheduling on the worker pool.
73 class CONTENT_EXPORT DOMStorageWorkerPoolTaskRunner : 64 class CONTENT_EXPORT DOMStorageWorkerPoolTaskRunner :
74 public DOMStorageTaskRunner { 65 public DOMStorageTaskRunner {
75 public: 66 public:
76 DOMStorageWorkerPoolTaskRunner( 67 DOMStorageWorkerPoolTaskRunner(
77 base::SequencedWorkerPool* sequenced_worker_pool, 68 base::SequencedWorkerPool* sequenced_worker_pool,
78 base::SequencedWorkerPool::SequenceToken primary_sequence_token, 69 base::SequencedWorkerPool::SequenceToken primary_sequence_token,
79 base::SequencedWorkerPool::SequenceToken commit_sequence_token, 70 base::SequencedWorkerPool::SequenceToken commit_sequence_token,
80 base::SingleThreadTaskRunner* delayed_task_task_runner); 71 base::SingleThreadTaskRunner* delayed_task_task_runner);
81 72
73 bool RunsTasksOnCurrentThread() const override;
74
82 bool PostDelayedTask(const tracked_objects::Location& from_here, 75 bool PostDelayedTask(const tracked_objects::Location& from_here,
83 const base::Closure& task, 76 const base::Closure& task,
84 base::TimeDelta delay) override; 77 base::TimeDelta delay) override;
85 78
86 bool PostShutdownBlockingTask(const tracked_objects::Location& from_here, 79 bool PostShutdownBlockingTask(const tracked_objects::Location& from_here,
87 SequenceID sequence_id, 80 SequenceID sequence_id,
88 const base::Closure& task) override; 81 const base::Closure& task) override;
89 82
90 bool IsRunningOnSequence(SequenceID sequence_id) const override; 83 void AssertIsRunningOnPrimarySequence() const override;
84 void AssertIsRunningOnCommitSequence() const override;
91 85
92 scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner( 86 scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner(
93 SequenceID sequence_id) override; 87 SequenceID sequence_id) override;
94 88
95 protected: 89 protected:
96 ~DOMStorageWorkerPoolTaskRunner() override; 90 ~DOMStorageWorkerPoolTaskRunner() override;
97 91
98 private: 92 private:
99 93
100 base::SequencedWorkerPool::SequenceToken IDtoToken(SequenceID id) const; 94 base::SequencedWorkerPool::SequenceToken IDtoToken(SequenceID id) const;
101 95
102 const scoped_refptr<base::SingleThreadTaskRunner> task_runner_; 96 const scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
103 const scoped_refptr<base::SequencedWorkerPool> sequenced_worker_pool_; 97 const scoped_refptr<base::SequencedWorkerPool> sequenced_worker_pool_;
104 base::SequencedWorkerPool::SequenceToken primary_sequence_token_; 98 base::SequencedWorkerPool::SequenceToken primary_sequence_token_;
99 base::SequenceChecker primary_sequence_checker_;
105 base::SequencedWorkerPool::SequenceToken commit_sequence_token_; 100 base::SequencedWorkerPool::SequenceToken commit_sequence_token_;
101 base::SequenceChecker commit_sequence_checker_;
106 }; 102 };
107 103
108 // A derived class used in unit tests that ignores all delays so 104 // A derived class used in unit tests that ignores all delays so
109 // we don't block in unit tests waiting for timeouts to expire. 105 // we don't block in unit tests waiting for timeouts to expire.
110 // There is no distinction between [non]-shutdown-blocking or 106 // There is no distinction between [non]-shutdown-blocking or
111 // the primary sequence vs the commit sequence in the mock, 107 // the primary sequence vs the commit sequence in the mock,
112 // all tasks are scheduled on |message_loop| with zero delay. 108 // all tasks are scheduled on |message_loop| with zero delay.
113 class CONTENT_EXPORT MockDOMStorageTaskRunner : 109 class CONTENT_EXPORT MockDOMStorageTaskRunner :
114 public DOMStorageTaskRunner { 110 public DOMStorageTaskRunner {
115 public: 111 public:
116 explicit MockDOMStorageTaskRunner(base::SingleThreadTaskRunner* task_runner); 112 explicit MockDOMStorageTaskRunner(base::SingleThreadTaskRunner* task_runner);
117 113
114 bool RunsTasksOnCurrentThread() const override;
115
118 bool PostDelayedTask(const tracked_objects::Location& from_here, 116 bool PostDelayedTask(const tracked_objects::Location& from_here,
119 const base::Closure& task, 117 const base::Closure& task,
120 base::TimeDelta delay) override; 118 base::TimeDelta delay) override;
121 119
122 bool PostShutdownBlockingTask(const tracked_objects::Location& from_here, 120 bool PostShutdownBlockingTask(const tracked_objects::Location& from_here,
123 SequenceID sequence_id, 121 SequenceID sequence_id,
124 const base::Closure& task) override; 122 const base::Closure& task) override;
125 123
126 bool IsRunningOnSequence(SequenceID sequence_id) const override; 124 void AssertIsRunningOnPrimarySequence() const override;
125 void AssertIsRunningOnCommitSequence() const override;
127 126
128 scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner( 127 scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner(
129 SequenceID sequence_id) override; 128 SequenceID sequence_id) override;
130 129
131 protected: 130 protected:
132 ~MockDOMStorageTaskRunner() override; 131 ~MockDOMStorageTaskRunner() override;
133 132
134 private: 133 private:
135 const scoped_refptr<base::SingleThreadTaskRunner> task_runner_; 134 const scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
136 }; 135 };
137 136
138 } // namespace content 137 } // namespace content
139 138
140 #endif // CONTENT_BROWSER_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_H_ 139 #endif // CONTENT_BROWSER_DOM_STORAGE_DOM_STORAGE_TASK_RUNNER_H_
OLDNEW
« no previous file with comments | « content/browser/dom_storage/dom_storage_namespace.cc ('k') | content/browser/dom_storage/dom_storage_task_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698