Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2317253006: Use GetCurrentStackPosition() to calculate the stack limit. (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 3 months ago
CC:
Michael Starzinger, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use GetCurrentStackPosition() to calculate the stack limit. The use of the address of a local variable causes problems with asan, see https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_triggered/builds/7803 R=jochen@chromium.org Committed: https://crrev.com/6fff60187aa19bbf569c9b1639153bf5f1a4bdcf Cr-Commit-Position: refs/heads/master@{#39330}

Patch Set 1 #

Patch Set 2 : Also change background-parsing-task.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M src/background-parsing-task.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
ahaas
4 years, 3 months ago (2016-09-09 13:57:59 UTC) #1
jochen (gone - plz use gerrit)
can you also fix the other two sites: https://cs.chromium.org/search/?q=file:src/v8+reinterpret.*stack.*limit&sq=package:chromium
4 years, 3 months ago (2016-09-09 14:01:10 UTC) #4
jochen (gone - plz use gerrit)
actually, the one in api.cc is probably ok
4 years, 3 months ago (2016-09-09 14:01:46 UTC) #5
ahaas
On 2016/09/09 at 14:01:10, jochen wrote: > can you also fix the other two sites: ...
4 years, 3 months ago (2016-09-09 14:52:20 UTC) #10
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-09 14:55:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317253006/20001
4 years, 3 months ago (2016-09-12 07:36:07 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-12 07:59:22 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 07:59:53 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6fff60187aa19bbf569c9b1639153bf5f1a4bdcf
Cr-Commit-Position: refs/heads/master@{#39330}

Powered by Google App Engine
This is Rietveld 408576698