Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: content/browser/renderer_host/render_widget_host_input_event_router.cc

Issue 2317253005: SourceEventType added to LatencyInfo (Closed)
Patch Set: Added a fake return to the end of EventTypeToLatencySourceEventType, for compilers that don't know … Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_input_event_router.cc
diff --git a/content/browser/renderer_host/render_widget_host_input_event_router.cc b/content/browser/renderer_host/render_widget_host_input_event_router.cc
index e3898e87afc9ad26b95c7ce13afdbb8ef9452777..68b19afed29ace6e202658fbb5c6eb2ea06a19c2 100644
--- a/content/browser/renderer_host/render_widget_host_input_event_router.cc
+++ b/content/browser/renderer_host/render_widget_host_input_event_router.cc
@@ -16,6 +16,7 @@
#include "content/browser/renderer_host/render_widget_host_view_base.h"
#include "content/common/frame_messages.h"
#include "third_party/WebKit/public/web/WebInputEvent.h"
+#include "ui/events/blink/web_input_event_traits.h"
namespace {
@@ -170,7 +171,8 @@ RenderWidgetHostViewBase* RenderWidgetHostInputEventRouter::FindEventTarget(
void RenderWidgetHostInputEventRouter::RouteMouseEvent(
RenderWidgetHostViewBase* root_view,
- blink::WebMouseEvent* event) {
+ blink::WebMouseEvent* event,
+ const ui::LatencyInfo& latency) {
RenderWidgetHostViewBase* target;
gfx::Point transformed_point;
const int mouse_button_modifiers = blink::WebInputEvent::LeftButtonDown |
@@ -206,15 +208,13 @@ void RenderWidgetHostInputEventRouter::RouteMouseEvent(
event->x = transformed_point.x();
event->y = transformed_point.y();
- // TODO(wjmaclean): Initialize latency info correctly for OOPIFs.
- // https://crbug.com/613628
- ui::LatencyInfo latency_info;
- target->ProcessMouseEvent(*event, latency_info);
+ target->ProcessMouseEvent(*event, latency);
}
void RenderWidgetHostInputEventRouter::RouteMouseWheelEvent(
RenderWidgetHostViewBase* root_view,
- blink::WebMouseWheelEvent* event) {
+ blink::WebMouseWheelEvent* event,
+ const ui::LatencyInfo& latency) {
gfx::Point transformed_point;
RenderWidgetHostViewBase* target = FindEventTarget(
root_view, gfx::Point(event->x, event->y), &transformed_point);
@@ -223,10 +223,7 @@ void RenderWidgetHostInputEventRouter::RouteMouseWheelEvent(
event->x = transformed_point.x();
event->y = transformed_point.y();
- // TODO(wjmaclean): Initialize latency info correctly for OOPIFs.
- // https://crbug.com/613628
- ui::LatencyInfo latency_info;
- target->ProcessMouseWheelEvent(*event, latency_info);
+ target->ProcessMouseWheelEvent(*event, latency);
}
void RenderWidgetHostInputEventRouter::RouteGestureEvent(
@@ -466,11 +463,14 @@ void RenderWidgetHostInputEventRouter::BubbleScrollEvent(
DCHECK(!first_bubbling_scroll_target_.target ==
!bubbling_gesture_scroll_target_.target);
+ ui::LatencyInfo latency_info =
+ ui::WebInputEventTraits::CreateLatencyInfoForWebGestureEvent(event);
+
// If target_view is already set up for bubbled scrolls, we forward
// the event to the current scroll target without further consideration.
if (target_view == first_bubbling_scroll_target_.target) {
- bubbling_gesture_scroll_target_.target->ProcessGestureEvent(
- event, ui::LatencyInfo());
+ bubbling_gesture_scroll_target_.target->ProcessGestureEvent(event,
+ latency_info);
if (event.type == blink::WebInputEvent::GestureScrollEnd) {
first_bubbling_scroll_target_.target = nullptr;
bubbling_gesture_scroll_target_.target = nullptr;
@@ -488,8 +488,8 @@ void RenderWidgetHostInputEventRouter::BubbleScrollEvent(
// have been sent to a renderer before the first one was ACKed, and the ACK
// caused a bubble retarget. In this case they all get forwarded.
if (target_view == bubbling_gesture_scroll_target_.target) {
- bubbling_gesture_scroll_target_.target->ProcessGestureEvent(
- event, ui::LatencyInfo());
+ bubbling_gesture_scroll_target_.target->ProcessGestureEvent(event,
+ latency_info);
return;
}
@@ -514,7 +514,7 @@ void RenderWidgetHostInputEventRouter::BubbleScrollEvent(
bubbling_gesture_scroll_target_.target = target_view;
SendGestureScrollBegin(target_view, event);
- target_view->ProcessGestureEvent(event, ui::LatencyInfo());
+ target_view->ProcessGestureEvent(event, latency_info);
}
void RenderWidgetHostInputEventRouter::SendGestureScrollBegin(
@@ -528,7 +528,9 @@ void RenderWidgetHostInputEventRouter::SendGestureScrollBegin(
scroll_begin.data.scrollBegin.deltaYHint = event.data.scrollUpdate.deltaY;
scroll_begin.data.scrollBegin.deltaHintUnits =
event.data.scrollUpdate.deltaUnits;
- view->ProcessGestureEvent(scroll_begin, ui::LatencyInfo());
+ view->ProcessGestureEvent(
+ scroll_begin,
+ ui::WebInputEventTraits::CreateLatencyInfoForWebGestureEvent(event));
}
void RenderWidgetHostInputEventRouter::SendGestureScrollEnd(
@@ -543,7 +545,9 @@ void RenderWidgetHostInputEventRouter::SendGestureScrollEnd(
scroll_end.data.scrollEnd.inertialPhase =
event.data.scrollUpdate.inertialPhase;
scroll_end.data.scrollEnd.deltaUnits = event.data.scrollUpdate.deltaUnits;
- view->ProcessGestureEvent(scroll_end, ui::LatencyInfo());
+ view->ProcessGestureEvent(
+ scroll_end,
+ ui::WebInputEventTraits::CreateLatencyInfoForWebGestureEvent(event));
}
void RenderWidgetHostInputEventRouter::CancelScrollBubbling(

Powered by Google App Engine
This is Rietveld 408576698