Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: git_cl.py

Issue 2317253003: Gerrit git cl land: abort if not uploaded. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 6cfb4bedb8a5e90b5f50a52258bffb90e51e1c83..a11004953222dad96fe29bbaf7cbefa72a78dac7 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -4009,6 +4009,10 @@ def SendUpstream(parser, args, cmd):
'the contributor\'s "name <email>". If you can\'t upload such a '
'commit for review, contact your repository admin and request'
'"Forge-Author" permission.')
+ if not cl.GetIssue():
+ DieWithError('You must upload the issue first to Gerrit.\n'
+ ' If you would rather have `git cl land` upload '
+ 'automatically for you, see http://crbug.com/642759')
return cl._codereview_impl.CMDLand(options.force, options.bypass_hooks,
options.verbose)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698