Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2317223002: LogDog/Butler: Enable direct output forwarding. (Closed)

Created:
4 years, 3 months ago by dnj
Modified:
4 years, 3 months ago
Reviewers:
iannucci
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog/Butler: Enable direct output forwarding. Currently, Butler supports either passing a subprocess' STDOUT/STDERR directly as a LogDog stream or completely ignoring them. This adds a third option: forwarding them through the Butler's STDOUT/STDERR. BUG=chromium:643243 TEST=local - Ran locally, seems to work. Committed: https://github.com/luci/luci-go/commit/11daeac05bb27ba6a5322cb653e06285fcff7040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -16 lines) Patch
M logdog/client/cmd/logdog_butler/subcommand_run.go View 3 chunks +36 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dnj
PTAL!
4 years, 3 months ago (2016-09-07 18:45:50 UTC) #2
iannucci
lgtm
4 years, 3 months ago (2016-09-07 19:03:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317223002/1
4 years, 3 months ago (2016-09-07 19:07:52 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 19:15:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/11daeac05bb27ba6a5322cb653e06285fcff7040

Powered by Google App Engine
This is Rietveld 408576698