third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 2317203002: Avoid mutating frame unique name after first real commit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2317203002: Avoid mutating frame unique name after first real commit. (Closed)

Patch Set: Tweaking the comment describing the format of unique name. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index ae3e9cf891a4b7e0b65b18344b50d90188858ef4..c034e88a5a595c185c68d5d6fa2f8df8579871c5 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -7599,9 +7599,10 @@ TEST_F(WebFrameSwapTest, UniqueNameAfterRemoteToLocalSwap)

EXPECT_EQ(uniqueName.utf8(), WebString(toWebLocalFrameImpl(localFrame)->frame()->loader().currentItem()->target()).utf8());

// Repeat with no name on the frame.

+ // (note that uniqueName is immutable after first real commit).

localFrame->setName("");

WebString uniqueName2 = localFrame->uniqueName();

- EXPECT_EQ("-->", uniqueName2.utf8());

+ EXPECT_EQ("frame1", uniqueName2.utf8());

FrameTestHelpers::TestWebRemoteFrameClient remoteFrameClient2;

WebRemoteFrameImpl* remoteFrame2 = WebRemoteFrameImpl::create(WebTreeScopeType::Document, &remoteFrameClient2);

« no previous file with comments | « third_party/WebKit/Source/core/page/FrameTree.cpp ('k') | no next file » | no next file with comments »