Start the Physical Web scanner on Chrome start

Start the Physical Web scanner on Chrome start

When Chrome is started, enable foreground scanning for Physical Web
URLs. The scanner will remain enabled until Chrome is closed or the
Physical Web preference is disabled, but scanning will only occur when
the Chrome app is in the foreground.

BUG=630769
Committed: https://crrev.com/09aacee5670d2cf85db2770183b89da173dd3359
Cr-Commit-Position: refs/heads/master@{#417411}

[mattreynolds, 2016-09-07 17:26:28]

mattreynolds@chromium.org changed reviewers:
+ sdefresne@chromium.org

[mattreynolds, 2016-09-07 17:26:28]

Hi Sylvain, PTAL

[sdefresne, 2016-09-08 15:20:16]

lgtm

https://codereview.chromium.org/2317183002/diff/1/ios/chrome/browser/physical...
File ios/chrome/browser/physical_web/start_physical_web_discovery.mm (right):

https://codereview.chromium.org/2317183002/diff/1/ios/chrome/browser/physical...
ios/chrome/browser/physical_web/start_physical_web_discovery.mm:34: if
(auth_status == kCLAuthorizationStatusAuthorizedWhenInUse ||
nit: I would swap the conditional here

if (auth_status != kCLAuthorizationStatusAuthorizedWhenInUse &&
    auth_status != kCLAuthorizationStatusAuthorizedAlways) {
  return;
}
pref_service->SetInteger(prefs::kIosPhysicalWebEnabled, true);

[mattreynolds, 2016-09-08 20:32:21]

Thanks Sylvain!

https://codereview.chromium.org/2317183002/diff/1/ios/chrome/browser/physical...
File ios/chrome/browser/physical_web/start_physical_web_discovery.mm (right):

https://codereview.chromium.org/2317183002/diff/1/ios/chrome/browser/physical...
ios/chrome/browser/physical_web/start_physical_web_discovery.mm:34: if
(auth_status == kCLAuthorizationStatusAuthorizedWhenInUse ||
On 2016/09/08 15:20:16, sdefresne wrote:
> nit: I would swap the conditional here
> 
> if (auth_status != kCLAuthorizationStatusAuthorizedWhenInUse &&
>     auth_status != kCLAuthorizationStatusAuthorizedAlways) {
>   return;
> }
> pref_service->SetInteger(prefs::kIosPhysicalWebEnabled, true);

Done.

[mattreynolds, 2016-09-08 20:32:25]

The CQ bit was checked by mattreynolds@chromium.org

[mattreynolds, 2016-09-08 20:32:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2317183002/#ps20001
(title: "swap conditional")

[commit-bot: I haz the power, 2016-09-08 20:33:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 21:57:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 22:01:55]

Description was changed from

==========
Start the Physical Web scanner on Chrome start

When Chrome is started, enable foreground scanning for Physical Web
URLs. The scanner will remain enabled until Chrome is closed or the
Physical Web preference is disabled, but scanning will only occur when
the Chrome app is in the foreground.

BUG=630769
==========

to

==========
Start the Physical Web scanner on Chrome start

When Chrome is started, enable foreground scanning for Physical Web
URLs. The scanner will remain enabled until Chrome is closed or the
Physical Web preference is disabled, but scanning will only occur when
the Chrome app is in the foreground.

BUG=630769

Committed: https://crrev.com/09aacee5670d2cf85db2770183b89da173dd3359
Cr-Commit-Position: refs/heads/master@{#417411}
==========

[commit-bot: I haz the power, 2016-09-08 22:01:56]

Patchset 2 (id:??) landed as
https://crrev.com/09aacee5670d2cf85db2770183b89da173dd3359
Cr-Commit-Position: refs/heads/master@{#417411}