Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2317163003: [Merge M54] Only report PasswordState in Sync for UMA+non-custom passphrase users. (Closed)

Created:
4 years, 3 months ago by Nathan Parker
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Merge M54] Only report PasswordState in Sync for UMA+non-custom passphrase users. BUG=641421, 643393 Review-Url: https://codereview.chromium.org/2302823003 Cr-Commit-Position: refs/heads/master@{#416659} (cherry picked from commit 8548bedfaf6c4a54b37de8f01821dff63544b85c) Committed: https://chromium.googlesource.com/chromium/src/+/91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -10 lines) Patch
M chrome/browser/metrics/chrome_metrics_service_accessor.h View 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_accessor.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 9 chunks +148 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Nathan Parker
4 years, 3 months ago (2016-09-07 22:29:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67.

Powered by Google App Engine
This is Rietveld 408576698