Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2317153003:
[NTP Snippets] Increase default expiry time to 3 days (Closed)
|
Created:
4 years, 3 months ago by Marc Treib Modified:
4 years, 3 months ago Reviewers:
jkrcal CC:
chromium-reviews, ntp-dev+reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[NTP Snippets] Increase default expiry time to 3 days
This matches what our backend (ChromeReader) does.
BUG=643605
Committed: https://crrev.com/ad733ade2afbda1dd439afc63818faf9a8420d60
Cr-Commit-Position: refs/heads/master@{#417256}
Patch Set 1 #
Messages
Total messages: 18 (13 generated)
Description was changed from ========== [NTP Snippets] Increase default expiry time to 3 days BUG=643605 ========== to ========== [NTP Snippets] Increase default expiry time to 3 days This matches what our backend (ChromeReader) does. BUG=643605 ==========
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
treib@chromium.org changed reviewers: + jkrcal@chromium.org
Hey, here's that humongous CL you've been expecting! PTAL :)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by treib@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [NTP Snippets] Increase default expiry time to 3 days This matches what our backend (ChromeReader) does. BUG=643605 ========== to ========== [NTP Snippets] Increase default expiry time to 3 days This matches what our backend (ChromeReader) does. BUG=643605 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [NTP Snippets] Increase default expiry time to 3 days This matches what our backend (ChromeReader) does. BUG=643605 ========== to ========== [NTP Snippets] Increase default expiry time to 3 days This matches what our backend (ChromeReader) does. BUG=643605 Committed: https://crrev.com/ad733ade2afbda1dd439afc63818faf9a8420d60 Cr-Commit-Position: refs/heads/master@{#417256} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ad733ade2afbda1dd439afc63818faf9a8420d60 Cr-Commit-Position: refs/heads/master@{#417256} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
