Blink roll 171141:171171

Blink roll 171141:171171

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171141:171171&mode=html
TBR=
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262863

[jianli, 2014-04-09 20:04:11]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-04-09 20:05:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jianli@chromium.org/231713002/1

[commit-bot: I haz the power, 2014-04-09 23:53:41]

Change committed as 262863

[tapted, 2014-04-10 03:01:49]

On 2014/04/09 23:53:41, I haz the power (commit-bot) wrote:
> Change committed as 262863

I think this is causing a compile error in the chromiumos build bot (gcc I
think). Waterfall: red.

Build:
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%...

Errors like 

chromeos-chrome-36.0.1933.0_alpha-r1: [605/1862] i686-pc-linux-gnu-g++ /* snip
*/ .../src/third_party/WebKit/Source/core/dom/CharacterData.cpp -o
obj/third_party/WebKit/Source/core/dom/webcore_dom.CharacterData.o
chromeos-chrome-36.0.1933.0_alpha-r1:
../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/dom/CharacterData.cpp:
In member function 'void WebCore::CharacterData::replaceData(unsigned int,
unsigned int, const WTF::String&, WebCore::ExceptionState&)':
chromeos-chrome-36.0.1933.0_alpha-r1:
../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/dom/CharacterData.cpp:146:36:
error: 'realCount' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
chromeos-chrome-36.0.1933.0_alpha-r1:      newStr.remove(offset, realCount);

[tapted, 2014-04-10 03:19:33]

A revert of this CL has been created in
https://codereview.chromium.org/232443002/ by tapted@chromium.org.

The reason for reverting is: Compile errors on chromiumos builder [multiple
cycles] due to 

https://src.chromium.org/viewvc/blink?revision=171165&view=revision

/third_party/WebKit/Source/core/dom/CharacterData.cpp:146:36:
error: 'realCount' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
chromeos-chrome-36.0.1933.0_alpha-r1:      newStr.remove(offset, realCount);

link:
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%....

[jianli, 2014-04-10 05:26:13]

I am wondering why the CQ did not catch this. Yurys, could you please work
with the trooper on this? Thanks.


On Wed, Apr 9, 2014 at 8:19 PM, <tapted@chromium.org> wrote:

> A revert of this CL has been created in
> https://codereview.chromium.org/232443002/ by tapted@chromium.org.
>
> The reason for reverting is: Compile errors on chromiumos builder [multiple
> cycles] due to
>
> https://src.chromium.org/viewvc/blink?revision=171165&view=revision
>
>
> /third_party/WebKit/Source/core/dom/CharacterData.cpp:146:36:
> error: 'realCount' may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> chromeos-chrome-36.0.1933.0_alpha-r1:      newStr.remove(offset,
> realCount);
>
> link:
> http://build.chromium.org/p/chromium.chromiumos/builders/
> ChromiumOS%20%28x86%29/builds/20955.
>
> https://codereview.chromium.org/231713002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jianli, 2014-04-10 05:35:13]

I just took a look at the codes that triggered this compiling error. It
seems to be a compiler bug or some sort of incosistent compiler warning
setup.

Also we don't have any CQ bot for ChromiumOS (x86). In addition, it seems
that we have inconsistency between the compiler used for Linux ChromiumOS
and x86 ChromiumOS.


On Wed, Apr 9, 2014 at 10:25 PM, Jian Li <jianli@chromium.org> wrote:

> I am wondering why the CQ did not catch this. Yurys, could you please work
> with the trooper on this? Thanks.
>
>
> On Wed, Apr 9, 2014 at 8:19 PM, <tapted@chromium.org> wrote:
>
>> A revert of this CL has been created in
>> https://codereview.chromium.org/232443002/ by tapted@chromium.org.
>>
>> The reason for reverting is: Compile errors on chromiumos builder
>> [multiple
>> cycles] due to
>>
>> https://src.chromium.org/viewvc/blink?revision=171165&view=revision
>>
>>
>> /third_party/WebKit/Source/core/dom/CharacterData.cpp:146:36:
>> error: 'realCount' may be used uninitialized in this function
>> [-Werror=maybe-uninitialized]
>> chromeos-chrome-36.0.1933.0_alpha-r1:      newStr.remove(offset,
>> realCount);
>>
>> link:
>> http://build.chromium.org/p/chromium.chromiumos/builders/
>> ChromiumOS%20%28x86%29/builds/20955.
>>
>> https://codereview.chromium.org/231713002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[yurys, 2014-04-10 07:12:40]

On 2014/04/10 05:26:13, jianli wrote:
> I am wondering why the CQ did not catch this. Yurys, could you please work
> with the trooper on this? Thanks.
> 
Sure, will do.

[yurys, 2014-04-10 07:43:31]

Landed fix upstream:
https://src.chromium.org/viewvc/blink?view=rev&revision=171240. The compiler
wrongly thought that  'realCount' variable can be used uninitialized. Now it
should be happy.