misc files R-U: Change ScopedTempDir::path() to GetPath()

ui/gfx/font_render_params_linux_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/font_render_params.h"
 
 #include "base/files/scoped_temp_dir.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "build/build_config.h"
@@ skipping 54 matching lines @@
   base::ScopedTempDir temp_dir_;
   const LinuxFontDelegate* original_font_delegate_;
   TestFontDelegate test_font_delegate_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FontRenderParamsTest);
 };
 
 TEST_F(FontRenderParamsTest, Default) {
   ASSERT_TRUE(LoadSystemFontIntoFontconfig("arial.ttf"));
-  ASSERT_TRUE(LoadConfigDataIntoFontconfig(temp_dir_.path(),
+  ASSERT_TRUE(LoadConfigDataIntoFontconfig(
+      temp_dir_.GetPath(),
       std::string(kFontconfigFileHeader) +
-      // Specify the desired defaults via a font match rather than a pattern
-      // match (since this is the style generally used in /etc/fonts/conf.d).
-      kFontconfigMatchFontHeader +
-      CreateFontconfigEditStanza("antialias", "bool", "true") +
-      CreateFontconfigEditStanza("autohint", "bool", "true") +
-      CreateFontconfigEditStanza("hinting", "bool", "true") +
-      CreateFontconfigEditStanza("hintstyle", "const", "hintslight") +
-      CreateFontconfigEditStanza("rgba", "const", "rgb") +
-      kFontconfigMatchFooter +
-      // Add a font match for Arial. Since it specifies a family, it shouldn't
-      // take effect when querying default settings.
-      kFontconfigMatchFontHeader +
-      CreateFontconfigTestStanza("family", "eq", "string", "Arial") +
-      CreateFontconfigEditStanza("antialias", "bool", "true") +
-      CreateFontconfigEditStanza("autohint", "bool", "false") +
-      CreateFontconfigEditStanza("hinting", "bool", "true") +
-      CreateFontconfigEditStanza("hintstyle", "const", "hintfull") +
-      CreateFontconfigEditStanza("rgba", "const", "none") +
-      kFontconfigMatchFooter +
-      // Add font matches for fonts between 10 and 20 points or pixels. Since
-      // they specify sizes, they also should not affect the defaults.
-      kFontconfigMatchFontHeader +
-      CreateFontconfigTestStanza("size", "more_eq", "double", "10.0") +
-      CreateFontconfigTestStanza("size", "less_eq", "double", "20.0") +
-      CreateFontconfigEditStanza("antialias", "bool", "false") +
-      kFontconfigMatchFooter +
-      kFontconfigMatchFontHeader +
-      CreateFontconfigTestStanza("pixel_size", "more_eq", "double", "10.0") +
-      CreateFontconfigTestStanza("pixel_size", "less_eq", "double", "20.0") +
-      CreateFontconfigEditStanza("antialias", "bool", "false") +
-      kFontconfigMatchFooter +
-      kFontconfigFileFooter));
+          // Specify the desired defaults via a font match rather than a pattern
+          // match (since this is the style generally used in
+          // /etc/fonts/conf.d).
+          kFontconfigMatchFontHeader +
+          CreateFontconfigEditStanza("antialias", "bool", "true") +
+          CreateFontconfigEditStanza("autohint", "bool", "true") +
+          CreateFontconfigEditStanza("hinting", "bool", "true") +
+          CreateFontconfigEditStanza("hintstyle", "const", "hintslight") +
+          CreateFontconfigEditStanza("rgba", "const", "rgb") +
+          kFontconfigMatchFooter +
+          // Add a font match for Arial. Since it specifies a family, it
+          // shouldn't
+          // take effect when querying default settings.
+          kFontconfigMatchFontHeader +
+          CreateFontconfigTestStanza("family", "eq", "string", "Arial") +
+          CreateFontconfigEditStanza("antialias", "bool", "true") +
+          CreateFontconfigEditStanza("autohint", "bool", "false") +
+          CreateFontconfigEditStanza("hinting", "bool", "true") +
+          CreateFontconfigEditStanza("hintstyle", "const", "hintfull") +
+          CreateFontconfigEditStanza("rgba", "const", "none") +
+          kFontconfigMatchFooter +
+          // Add font matches for fonts between 10 and 20 points or pixels.
+          // Since
+          // they specify sizes, they also should not affect the defaults.
+          kFontconfigMatchFontHeader +
+          CreateFontconfigTestStanza("size", "more_eq", "double", "10.0") +
+          CreateFontconfigTestStanza("size", "less_eq", "double", "20.0") +
+          CreateFontconfigEditStanza("antialias", "bool", "false") +
+          kFontconfigMatchFooter + kFontconfigMatchFontHeader +
+          CreateFontconfigTestStanza("pixel_size", "more_eq", "double",
+                                     "10.0") +
+          CreateFontconfigTestStanza("pixel_size", "less_eq", "double",
+                                     "20.0") +
+          CreateFontconfigEditStanza("antialias", "bool", "false") +
+          kFontconfigMatchFooter + kFontconfigFileFooter));
 
   FontRenderParams params = GetFontRenderParams(
       FontRenderParamsQuery(), NULL);
   EXPECT_TRUE(params.antialiasing);
   EXPECT_TRUE(params.autohinter);
   EXPECT_TRUE(params.use_bitmaps);
   EXPECT_EQ(FontRenderParams::HINTING_SLIGHT, params.hinting);
   EXPECT_FALSE(params.subpixel_positioning);
   EXPECT_EQ(FontRenderParams::SUBPIXEL_RENDERING_RGB,
             params.subpixel_rendering);
 }
 
 TEST_F(FontRenderParamsTest, Size) {
   ASSERT_TRUE(LoadSystemFontIntoFontconfig("arial.ttf"));
-  ASSERT_TRUE(LoadConfigDataIntoFontconfig(temp_dir_.path(),
-      std::string(kFontconfigFileHeader) +
-      kFontconfigMatchPatternHeader +
-      CreateFontconfigEditStanza("antialias", "bool", "true") +
-      CreateFontconfigEditStanza("hinting", "bool", "true") +
-      CreateFontconfigEditStanza("hintstyle", "const", "hintfull") +
-      CreateFontconfigEditStanza("rgba", "const", "none") +
-      kFontconfigMatchFooter +
-      kFontconfigMatchPatternHeader +
-      CreateFontconfigTestStanza("pixelsize", "less_eq", "double", "10") +
-      CreateFontconfigEditStanza("antialias", "bool", "false") +
-      kFontconfigMatchFooter +
-      kFontconfigMatchPatternHeader +
-      CreateFontconfigTestStanza("size", "more_eq", "double", "20") +
-      CreateFontconfigEditStanza("hintstyle", "const", "hintslight") +
-      CreateFontconfigEditStanza("rgba", "const", "rgb") +
-      kFontconfigMatchFooter +
-      kFontconfigFileFooter));
+  ASSERT_TRUE(LoadConfigDataIntoFontconfig(
+      temp_dir_.GetPath(),
+      std::string(kFontconfigFileHeader) + kFontconfigMatchPatternHeader +
+          CreateFontconfigEditStanza("antialias", "bool", "true") +
+          CreateFontconfigEditStanza("hinting", "bool", "true") +
+          CreateFontconfigEditStanza("hintstyle", "const", "hintfull") +
+          CreateFontconfigEditStanza("rgba", "const", "none") +
+          kFontconfigMatchFooter + kFontconfigMatchPatternHeader +
+          CreateFontconfigTestStanza("pixelsize", "less_eq", "double", "10") +
+          CreateFontconfigEditStanza("antialias", "bool", "false") +
+          kFontconfigMatchFooter + kFontconfigMatchPatternHeader +
+          CreateFontconfigTestStanza("size", "more_eq", "double", "20") +
+          CreateFontconfigEditStanza("hintstyle", "const", "hintslight") +
+          CreateFontconfigEditStanza("rgba", "const", "rgb") +
+          kFontconfigMatchFooter + kFontconfigFileFooter));
 
   // The defaults should be used when the supplied size isn't matched by the
   // second or third blocks.
   FontRenderParamsQuery query;
   query.pixel_size = 12;
   FontRenderParams params = GetFontRenderParams(query, NULL);
   EXPECT_TRUE(params.antialiasing);
   EXPECT_EQ(FontRenderParams::HINTING_FULL, params.hinting);
   EXPECT_EQ(FontRenderParams::SUBPIXEL_RENDERING_NONE,
             params.subpixel_rendering);
@@ skipping 11 matching lines @@
   EXPECT_TRUE(params.antialiasing);
   EXPECT_EQ(FontRenderParams::HINTING_SLIGHT, params.hinting);
   EXPECT_EQ(FontRenderParams::SUBPIXEL_RENDERING_RGB,
             params.subpixel_rendering);
 }
 
 TEST_F(FontRenderParamsTest, Style) {
   ASSERT_TRUE(LoadSystemFontIntoFontconfig("arial.ttf"));
   // Load a config that disables subpixel rendering for bold text and disables
   // hinting for italic text.
-  ASSERT_TRUE(LoadConfigDataIntoFontconfig(temp_dir_.path(),
-      std::string(kFontconfigFileHeader) +
-      kFontconfigMatchPatternHeader +
-      CreateFontconfigEditStanza("antialias", "bool", "true") +
-      CreateFontconfigEditStanza("hinting", "bool", "true") +
-      CreateFontconfigEditStanza("hintstyle", "const", "hintslight") +
-      CreateFontconfigEditStanza("rgba", "const", "rgb") +
-      kFontconfigMatchFooter +
-      kFontconfigMatchPatternHeader +
-      CreateFontconfigTestStanza("weight", "eq", "const", "bold") +
-      CreateFontconfigEditStanza("rgba", "const", "none") +
-      kFontconfigMatchFooter +
-      kFontconfigMatchPatternHeader +
-      CreateFontconfigTestStanza("slant", "eq", "const", "italic") +
-      CreateFontconfigEditStanza("hinting", "bool", "false") +
-      kFontconfigMatchFooter +
-      kFontconfigFileFooter));
+  ASSERT_TRUE(LoadConfigDataIntoFontconfig(
+      temp_dir_.GetPath(),
+      std::string(kFontconfigFileHeader) + kFontconfigMatchPatternHeader +
+          CreateFontconfigEditStanza("antialias", "bool", "true") +
+          CreateFontconfigEditStanza("hinting", "bool", "true") +
+          CreateFontconfigEditStanza("hintstyle", "const", "hintslight") +
+          CreateFontconfigEditStanza("rgba", "const", "rgb") +
+          kFontconfigMatchFooter + kFontconfigMatchPatternHeader +
+          CreateFontconfigTestStanza("weight", "eq", "const", "bold") +
+          CreateFontconfigEditStanza("rgba", "const", "none") +
+          kFontconfigMatchFooter + kFontconfigMatchPatternHeader +
+          CreateFontconfigTestStanza("slant", "eq", "const", "italic") +
+          CreateFontconfigEditStanza("hinting", "bool", "false") +
+          kFontconfigMatchFooter + kFontconfigFileFooter));
 
   FontRenderParamsQuery query;
   query.style = Font::NORMAL;
   FontRenderParams params = GetFontRenderParams(query, NULL);
   EXPECT_EQ(FontRenderParams::HINTING_SLIGHT, params.hinting);
   EXPECT_EQ(FontRenderParams::SUBPIXEL_RENDERING_RGB,
             params.subpixel_rendering);
 
   query.weight = Font::Weight::BOLD;
   params = GetFontRenderParams(query, NULL);
@@ skipping 11 matching lines @@
   query.weight = Font::Weight::BOLD;
   query.style = Font::ITALIC;
   params = GetFontRenderParams(query, NULL);
   EXPECT_EQ(FontRenderParams::HINTING_NONE, params.hinting);
   EXPECT_EQ(FontRenderParams::SUBPIXEL_RENDERING_NONE,
             params.subpixel_rendering);
 }
 
 TEST_F(FontRenderParamsTest, Scalable) {
   // Load a config that only enables antialiasing for scalable fonts.
-  ASSERT_TRUE(LoadConfigDataIntoFontconfig(temp_dir_.path(),
-      std::string(kFontconfigFileHeader) +
-      kFontconfigMatchPatternHeader +
-      CreateFontconfigEditStanza("antialias", "bool", "false") +
-      kFontconfigMatchFooter +
-      kFontconfigMatchPatternHeader +
-      CreateFontconfigTestStanza("scalable", "eq", "bool", "true") +
-      CreateFontconfigEditStanza("antialias", "bool", "true") +
-      kFontconfigMatchFooter +
-      kFontconfigFileFooter));
+  ASSERT_TRUE(LoadConfigDataIntoFontconfig(
+      temp_dir_.GetPath(),
+      std::string(kFontconfigFileHeader) + kFontconfigMatchPatternHeader +
+          CreateFontconfigEditStanza("antialias", "bool", "false") +
+          kFontconfigMatchFooter + kFontconfigMatchPatternHeader +
+          CreateFontconfigTestStanza("scalable", "eq", "bool", "true") +
+          CreateFontconfigEditStanza("antialias", "bool", "true") +
+          kFontconfigMatchFooter + kFontconfigFileFooter));
 
   // Check that we specifically ask how scalable fonts should be rendered.
   FontRenderParams params = GetFontRenderParams(
       FontRenderParamsQuery(), NULL);
   EXPECT_TRUE(params.antialiasing);
 }
 
 TEST_F(FontRenderParamsTest, UseBitmaps) {
   ASSERT_TRUE(LoadSystemFontIntoFontconfig("arial.ttf"));
   // Load a config that enables embedded bitmaps for fonts <= 10 pixels.
-  ASSERT_TRUE(LoadConfigDataIntoFontconfig(temp_dir_.path(),
-      std::string(kFontconfigFileHeader) +
-      kFontconfigMatchPatternHeader +
-      CreateFontconfigEditStanza("embeddedbitmap", "bool", "false") +
-      kFontconfigMatchFooter +
-      kFontconfigMatchPatternHeader +
-      CreateFontconfigTestStanza("pixelsize", "less_eq", "double", "10") +
-      CreateFontconfigEditStanza("embeddedbitmap", "bool", "true") +
-      kFontconfigMatchFooter +
-      kFontconfigFileFooter));
+  ASSERT_TRUE(LoadConfigDataIntoFontconfig(
+      temp_dir_.GetPath(),
+      std::string(kFontconfigFileHeader) + kFontconfigMatchPatternHeader +
+          CreateFontconfigEditStanza("embeddedbitmap", "bool", "false") +
+          kFontconfigMatchFooter + kFontconfigMatchPatternHeader +
+          CreateFontconfigTestStanza("pixelsize", "less_eq", "double", "10") +
+          CreateFontconfigEditStanza("embeddedbitmap", "bool", "true") +
+          kFontconfigMatchFooter + kFontconfigFileFooter));
 
   FontRenderParamsQuery query;
   FontRenderParams params = GetFontRenderParams(query, NULL);
   EXPECT_FALSE(params.use_bitmaps);
 
   query.pixel_size = 5;
   params = GetFontRenderParams(query, NULL);
   EXPECT_TRUE(params.use_bitmaps);
 }
 
 TEST_F(FontRenderParamsTest, ForceFullHintingWhenAntialiasingIsDisabled) {
   // Load a config that disables antialiasing and hinting while requesting
   // subpixel rendering.
-  ASSERT_TRUE(LoadConfigDataIntoFontconfig(temp_dir_.path(),
-      std::string(kFontconfigFileHeader) +
-      kFontconfigMatchPatternHeader +
-      CreateFontconfigEditStanza("antialias", "bool", "false") +
-      CreateFontconfigEditStanza("hinting", "bool", "false") +
-      CreateFontconfigEditStanza("hintstyle", "const", "hintnone") +
-      CreateFontconfigEditStanza("rgba", "const", "rgb") +
-      kFontconfigMatchFooter +
-      kFontconfigFileFooter));
+  ASSERT_TRUE(LoadConfigDataIntoFontconfig(
+      temp_dir_.GetPath(),
+      std::string(kFontconfigFileHeader) + kFontconfigMatchPatternHeader +
+          CreateFontconfigEditStanza("antialias", "bool", "false") +
+          CreateFontconfigEditStanza("hinting", "bool", "false") +
+          CreateFontconfigEditStanza("hintstyle", "const", "hintnone") +
+          CreateFontconfigEditStanza("rgba", "const", "rgb") +
+          kFontconfigMatchFooter + kFontconfigFileFooter));
 
   // Full hinting should be forced. See the comment in GetFontRenderParams() for
   // more information.
   FontRenderParams params = GetFontRenderParams(
       FontRenderParamsQuery(), NULL);
   EXPECT_FALSE(params.antialiasing);
   EXPECT_EQ(FontRenderParams::HINTING_FULL, params.hinting);
   EXPECT_EQ(FontRenderParams::SUBPIXEL_RENDERING_NONE,
             params.subpixel_rendering);
   EXPECT_FALSE(params.subpixel_positioning);
@@ skipping 21 matching lines @@
 
 TEST_F(FontRenderParamsTest, OnlySetConfiguredValues) {
   // Configure the LinuxFontDelegate (which queries GtkSettings on desktop
   // Linux) to request subpixel rendering.
   FontRenderParams system_params;
   system_params.subpixel_rendering = FontRenderParams::SUBPIXEL_RENDERING_RGB;
   test_font_delegate_.set_params(system_params);
 
   // Load a Fontconfig config that enables antialiasing but doesn't say anything
   // about subpixel rendering.
-  ASSERT_TRUE(LoadConfigDataIntoFontconfig(temp_dir_.path(),
-      std::string(kFontconfigFileHeader) +
-      kFontconfigMatchPatternHeader +
-      CreateFontconfigEditStanza("antialias", "bool", "true") +
-      kFontconfigMatchFooter +
-      kFontconfigFileFooter));
+  ASSERT_TRUE(LoadConfigDataIntoFontconfig(
+      temp_dir_.GetPath(),
+      std::string(kFontconfigFileHeader) + kFontconfigMatchPatternHeader +
+          CreateFontconfigEditStanza("antialias", "bool", "true") +
+          kFontconfigMatchFooter + kFontconfigFileFooter));
 
   // The subpixel rendering setting from the delegate should make it through.
   FontRenderParams params = GetFontRenderParams(
       FontRenderParamsQuery(), NULL);
   EXPECT_EQ(system_params.subpixel_rendering, params.subpixel_rendering);
 }
 
 TEST_F(FontRenderParamsTest, NoFontconfigMatch) {
   // Don't load a Fontconfig configuration.
   FontRenderParams system_params;
@@ skipping 27 matching lines @@
   query.families.push_back("Verdana");
   std::string suggested_family;
   GetFontRenderParams(query, &suggested_family);
   EXPECT_EQ("Arial", suggested_family);
 }
 
 TEST_F(FontRenderParamsTest, SubstituteFamily) {
   // Configure Fontconfig to use Verdana for both Helvetica and Arial.
   ASSERT_TRUE(LoadSystemFontIntoFontconfig("arial.ttf"));
   ASSERT_TRUE(LoadSystemFontIntoFontconfig("verdana.ttf"));
-  ASSERT_TRUE(LoadConfigDataIntoFontconfig(temp_dir_.path(),
+  ASSERT_TRUE(LoadConfigDataIntoFontconfig(
+      temp_dir_.GetPath(),
       std::string(kFontconfigFileHeader) +
-      CreateFontconfigAliasStanza("Helvetica", "Verdana") +
-      kFontconfigMatchPatternHeader +
-      CreateFontconfigTestStanza("family", "eq", "string", "Arial") +
-      CreateFontconfigEditStanza("family", "string", "Verdana") +
-      kFontconfigMatchFooter +
-      kFontconfigFileFooter));
+          CreateFontconfigAliasStanza("Helvetica", "Verdana") +
+          kFontconfigMatchPatternHeader +
+          CreateFontconfigTestStanza("family", "eq", "string", "Arial") +
+          CreateFontconfigEditStanza("family", "string", "Verdana") +
+          kFontconfigMatchFooter + kFontconfigFileFooter));
 
   FontRenderParamsQuery query;
   query.families.push_back("Helvetica");
   std::string suggested_family;
   GetFontRenderParams(query, &suggested_family);
   EXPECT_EQ("Verdana", suggested_family);
 
   query.families.clear();
   query.families.push_back("Arial");
   suggested_family.clear();
   GetFontRenderParams(query, &suggested_family);
   EXPECT_EQ("Verdana", suggested_family);
 }
 
 }  // namespace gfx