Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2317123002: c/browser, c/common, components O-P: Change ScopedTempDir::path() to GetPath() (Closed)

Created:
4 years, 3 months ago by vabr (Chromium)
Modified:
4 years, 3 months ago
CC:
chili+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dewittj+watch_chromium.org, dimich+watch_chromium.org, fgorski+watch_chromium.org, jam, petewil+watch_chromium.org, rginda+watch_chromium.org, romax+watch_chromium.org, wifiprefetch-reviews_google.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

c/browser, c/common, components O-P: Change ScopedTempDir::path() to GetPath() path() is being deprecated, GetPath() has better checking against wrong use. For more context, see https://codereview.chromium.org/2275553005/. BUG=640599 Committed: https://crrev.com/8023d87a36c3eb4aacbf3e9ea427ecf9b572880f Cr-Commit-Position: refs/heads/master@{#418804}

Patch Set 1 #

Patch Set 2 : Just rebased #

Patch Set 3 : Just rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -187 lines) Patch
M chrome/browser/platform_util_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/policy/test/local_policy_test_server.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/prefs/pref_functional_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager_unittest.cc View 1 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/printing/pdf_to_emf_converter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_pdf_generated_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/printing/pwg_raster_converter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton_posix.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/process_singleton_posix_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton_win_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_unittest.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/profiles/profile_browsertest.cc View 11 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 23 chunks +43 lines, -43 lines 0 comments Download
M components/offline_pages/archive_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/offline_pages/background/request_queue_store_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/offline_page_metadata_store_impl_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/offline_pages/offline_page_model_impl_unittest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M components/omnibox/browser/history_quick_provider_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M components/omnibox/browser/history_url_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/omnibox/browser/in_memory_url_index_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M components/omnibox/browser/shortcuts_backend_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/omnibox/browser/shortcuts_database_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/omnibox/browser/shortcuts_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/ownership/owner_key_util_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/resource_cache_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/core/common/config_dir_policy_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_loader_win_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/precache/content/precache_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/precache/core/precache_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/precache/core/precache_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/prefs/json_pref_store_unittest.cc View 16 chunks +21 lines, -21 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (13 generated)
vabr (Chromium)
Hi Jochen, Could you please do another rubber-stamp? This is again just the mechanical renaming, ...
4 years, 3 months ago (2016-09-14 16:02:15 UTC) #11
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-14 16:03:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317123002/40001
4 years, 3 months ago (2016-09-15 08:07:16 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-15 08:12:41 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 08:14:24 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8023d87a36c3eb4aacbf3e9ea427ecf9b572880f
Cr-Commit-Position: refs/heads/master@{#418804}

Powered by Google App Engine
This is Rietveld 408576698