Issue 2317113005: Remove StringUtils from java_core.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2317113005: Remove StringUtils from java_core. (Closed)

Created:
4 years, 3 months ago by scheglov

Modified:
4 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Remove StringUtils from java_core. It is used almost only in analyzer and analysis_server. There are two places where it is used internally - I'm fixing them. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e187e339232808c60155c4ddf100c423cca5490c

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -105 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/assist_internal.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/extract_method.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/java_core.dart	View	1 chunk	+0 lines, -72 lines	0 comments	Download
M	pkg/analyzer/test/generated/test_support.dart	View	2 chunks	+14 lines, -28 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 3 months ago (2016-09-08 20:27:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e187e339232808c60155c4ddf100c423cca5490c (presubmit successful).