Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: components/spellcheck/renderer/spellcheck_provider.cc

Issue 2317113004: [Android][Mac] Enable spellcheck caching on Android and Mac platforms. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/spellcheck/renderer/spellcheck_provider.cc
diff --git a/components/spellcheck/renderer/spellcheck_provider.cc b/components/spellcheck/renderer/spellcheck_provider.cc
index 591f26324528ba5e260bc87ec1b65689a39e8390..f52fe596705c94e675d860375170502247e45779 100644
--- a/components/spellcheck/renderer/spellcheck_provider.cc
+++ b/components/spellcheck/renderer/spellcheck_provider.cc
@@ -260,9 +260,9 @@ void SpellCheckProvider::OnRespondTextCheck(
&textcheck_results);
completion->didFinishCheckingText(textcheck_results);
- // TODO(groby): Add request caching once OSX reports back original request.
- // (cf. SpellCheckProvider::OnRespondSpellingService)
// Cache the request and the converted results.
+ last_request_ = line;
groby-ooo-7-16 2016/09/09 22:41:38 Did you verify OSX actually returns the original r
timvolodine 2016/09/12 15:31:39 Yes, tested this on Mac OS X, it does return the "
+ last_results_.swap(textcheck_results);
}
void SpellCheckProvider::OnToggleSpellPanel(bool is_currently_visible) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698