[Android][Mac] Enable spellcheck caching on Android and Mac platforms.

[Android][Mac] Enable spellcheck caching on Android and Mac platforms.

This patch enables caching of spellcheck results to improve performance
and address issues mentioned below.

In its current state i.e. without caching spellcheck on Android and Mac
has a number of issues e.g.:
- selection (click) of words or movement of the caret can result
in unnecessary calls to the platform spellchecker.
- typing of non-word characters in the end results in unnecessary
calls to the platform spellchecker.
- modifying text does not always result in invocation of spellchecker,
hence not showing the misspelled words.

BUG=583616, 629609
Committed: https://crrev.com/1653062cd62db1cda12c6368929e64d6c8d866a7
Cr-Commit-Position: refs/heads/master@{#418631}

[timvolodine, 2016-09-08 15:15:43]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 15:15:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2016-09-08 15:16:57]

Description was changed from

==========
[Android][Mac] Enable spellcheck caching on Mac and Android platforms.

This patch enables caching of spellcheck results to improve performance
and address issues mentioned below.

In its current state i.e. without caching spellcheck on Android and Mac
has a number of issues e.g.:
- selection (click) of words or movement of the caret can result
in unnecessary calls to the platform spellchecker.
- typing of non-word characters in the end results in unnecessary
calls to the platform spellchecker.
- modyfying text does not always result in invocation of spellchecker,
hence not showing the misspelled words.

BUG=583616, 629609
==========

to

==========
[Android][Mac] Enable spellcheck caching on Android and Mac platforms.

This patch enables caching of spellcheck results to improve performance
and address issues mentioned below.

In its current state i.e. without caching spellcheck on Android and Mac
has a number of issues e.g.:
- selection (click) of words or movement of the caret can result
in unnecessary calls to the platform spellchecker.
- typing of non-word characters in the end results in unnecessary
calls to the platform spellchecker.
- modifying text does not always result in invocation of spellchecker,
hence not showing the misspelled words.

BUG=583616, 629609
==========

[timvolodine, 2016-09-08 15:18:07]

timvolodine@chromium.org changed reviewers:
+ groby@chromium.org

[commit-bot: I haz the power, 2016-09-08 16:27:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 16:27:40]

Dry run: This issue passed the CQ dry run.

[groby-ooo-7-16, 2016-09-09 22:41:38]

https://codereview.chromium.org/2317113004/diff/1/components/spellcheck/rende...
File components/spellcheck/renderer/spellcheck_provider.cc (right):

https://codereview.chromium.org/2317113004/diff/1/components/spellcheck/rende...
components/spellcheck/renderer/spellcheck_provider.cc:264: last_request_ = line;
Did you verify OSX actually returns the original request? Quick glance at the
code seems to confirm that, but I've not looked in depth.

[timvolodine, 2016-09-12 15:31:39]

https://codereview.chromium.org/2317113004/diff/1/components/spellcheck/rende...
File components/spellcheck/renderer/spellcheck_provider.cc (right):

https://codereview.chromium.org/2317113004/diff/1/components/spellcheck/rende...
components/spellcheck/renderer/spellcheck_provider.cc:264: last_request_ = line;
On 2016/09/09 22:41:38, groby wrote:
> Did you verify OSX actually returns the original request? Quick glance at the
> code seems to confirm that, but I've not looked in depth.

Yes, tested this on Mac OS X, it does return the "line" properly, and caching
appears to work.

[groby-ooo-7-16, 2016-09-12 18:20:09]

On 2016/09/12 15:31:39, timvolodine wrote:
>
https://codereview.chromium.org/2317113004/diff/1/components/spellcheck/rende...
> File components/spellcheck/renderer/spellcheck_provider.cc (right):
> 
>
https://codereview.chromium.org/2317113004/diff/1/components/spellcheck/rende...
> components/spellcheck/renderer/spellcheck_provider.cc:264: last_request_ =
line;
> On 2016/09/09 22:41:38, groby wrote:
> > Did you verify OSX actually returns the original request? Quick glance at
the
> > code seems to confirm that, but I've not looked in depth.
> 
> Yes, tested this on Mac OS X, it does return the "line" properly, and caching
> appears to work.

Woohoo! LGTM!

[timvolodine, 2016-09-14 17:58:12]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2016-09-14 17:58:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 19:07:50]

Description was changed from

==========
[Android][Mac] Enable spellcheck caching on Android and Mac platforms.

This patch enables caching of spellcheck results to improve performance
and address issues mentioned below.

In its current state i.e. without caching spellcheck on Android and Mac
has a number of issues e.g.:
- selection (click) of words or movement of the caret can result
in unnecessary calls to the platform spellchecker.
- typing of non-word characters in the end results in unnecessary
calls to the platform spellchecker.
- modifying text does not always result in invocation of spellchecker,
hence not showing the misspelled words.

BUG=583616, 629609
==========

to

==========
[Android][Mac] Enable spellcheck caching on Android and Mac platforms.

This patch enables caching of spellcheck results to improve performance
and address issues mentioned below.

In its current state i.e. without caching spellcheck on Android and Mac
has a number of issues e.g.:
- selection (click) of words or movement of the caret can result
in unnecessary calls to the platform spellchecker.
- typing of non-word characters in the end results in unnecessary
calls to the platform spellchecker.
- modifying text does not always result in invocation of spellchecker,
hence not showing the misspelled words.

BUG=583616, 629609
==========

[commit-bot: I haz the power, 2016-09-14 19:07:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-14 19:11:50]

Description was changed from

==========
[Android][Mac] Enable spellcheck caching on Android and Mac platforms.

This patch enables caching of spellcheck results to improve performance
and address issues mentioned below.

In its current state i.e. without caching spellcheck on Android and Mac
has a number of issues e.g.:
- selection (click) of words or movement of the caret can result
in unnecessary calls to the platform spellchecker.
- typing of non-word characters in the end results in unnecessary
calls to the platform spellchecker.
- modifying text does not always result in invocation of spellchecker,
hence not showing the misspelled words.

BUG=583616, 629609
==========

to

==========
[Android][Mac] Enable spellcheck caching on Android and Mac platforms.

This patch enables caching of spellcheck results to improve performance
and address issues mentioned below.

In its current state i.e. without caching spellcheck on Android and Mac
has a number of issues e.g.:
- selection (click) of words or movement of the caret can result
in unnecessary calls to the platform spellchecker.
- typing of non-word characters in the end results in unnecessary
calls to the platform spellchecker.
- modifying text does not always result in invocation of spellchecker,
hence not showing the misspelled words.

BUG=583616, 629609

Committed: https://crrev.com/1653062cd62db1cda12c6368929e64d6c8d866a7
Cr-Commit-Position: refs/heads/master@{#418631}
==========

[commit-bot: I haz the power, 2016-09-14 19:11:51]

Patchset 1 (id:??) landed as
https://crrev.com/1653062cd62db1cda12c6368929e64d6c8d866a7
Cr-Commit-Position: refs/heads/master@{#418631}