Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2317113002: Remove ::shadow and /deep/ combinator from Files app. (Closed)

Created:
4 years, 3 months ago by fukino
Modified:
4 years, 3 months ago
Reviewers:
oka
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ::shadow and /deep/ combinator from Files app. ::shadow and /deep/ combinator are deprecated. We need to use CSS variables instead. BUG=498405 TEST=manually confirmed that color/opacity doesn't change. Committed: https://crrev.com/fe885c5505b44a95ed6dc3d2d33e80a33c9a0238 Cr-Commit-Position: refs/heads/master@{#417143}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -55 lines) Patch
M ui/file_manager/audio_player/elements/control_panel.css View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_manager.css View 3 chunks +1 line, -33 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_icon_button.html View 1 chunk +0 lines, -5 lines 2 comments Download
M ui/file_manager/file_manager/foreground/elements/files_quick_view.css View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_toggle_ripple.html View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_toggle_ripple.js View 1 chunk +5 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +34 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/css/gallery.css View 3 chunks +2 lines, -12 lines 0 comments Download
M ui/file_manager/gallery/gallery.html View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fukino
PTAL https://codereview.chromium.org/2317113002/diff/1/ui/file_manager/file_manager/foreground/elements/files_icon_button.html File ui/file_manager/file_manager/foreground/elements/files_icon_button.html (left): https://codereview.chromium.org/2317113002/diff/1/ui/file_manager/file_manager/foreground/elements/files_icon_button.html#oldcode50 ui/file_manager/file_manager/foreground/elements/files_icon_button.html:50: files-toggle-ripple::shadow .ripple { I guess that the opacity ...
4 years, 3 months ago (2016-09-07 13:40:18 UTC) #2
oka
lgtm https://codereview.chromium.org/2317113002/diff/1/ui/file_manager/file_manager/foreground/elements/files_icon_button.html File ui/file_manager/file_manager/foreground/elements/files_icon_button.html (left): https://codereview.chromium.org/2317113002/diff/1/ui/file_manager/file_manager/foreground/elements/files_icon_button.html#oldcode50 ui/file_manager/file_manager/foreground/elements/files_icon_button.html:50: files-toggle-ripple::shadow .ripple { On 2016/09/07 13:40:18, fukino wrote: ...
4 years, 3 months ago (2016-09-08 00:19:33 UTC) #3
fukino
Thank you for the review!
4 years, 3 months ago (2016-09-08 00:32:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317113002/1
4 years, 3 months ago (2016-09-08 00:33:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 01:16:29 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 01:19:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe885c5505b44a95ed6dc3d2d33e80a33c9a0238
Cr-Commit-Position: refs/heads/master@{#417143}

Powered by Google App Engine
This is Rietveld 408576698