Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: pkg/barback/lib/src/phase.dart

Issue 23171020: Enable cross-package transforms to see new transformers in other packages. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/barback/lib/src/phase_output.dart » ('j') | pkg/barback/lib/src/phase_output.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/phase.dart
diff --git a/pkg/barback/lib/src/phase.dart b/pkg/barback/lib/src/phase.dart
index af20bc7e2f26eeed51999e7eee9027e9d3ccbf8f..6ad4ea68411a3c83cf6b8d8a83dac0d423dd2812 100644
--- a/pkg/barback/lib/src/phase.dart
+++ b/pkg/barback/lib/src/phase.dart
@@ -139,8 +139,12 @@ class Phase {
Phase addPhase(Iterable<Transformer> transformers) {
assert(_next == null);
_next = new Phase(cascade, transformers);
- for (var outputs in _outputs.values) {
- _next.addInput(outputs.output);
+ for (var output in _outputs.values.toList()) {
+ output.removeListeners();
Bob Nystrom 2013/08/22 19:34:19 Document why its listeners are being removed.
+ // Removing [output]'s listeners will cause it to be removed from
+ // [_outputs], so we have to put it back.
+ _outputs[output.output.id] = output;
+ _next.addInput(output.output);
}
return _next;
}
« no previous file with comments | « no previous file | pkg/barback/lib/src/phase_output.dart » ('j') | pkg/barback/lib/src/phase_output.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698