Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: sdk/lib/_internal/compiler/implementation/resolved_visitor.dart

Issue 23171004: Fix resolved visitor to dispatch a constructor redirection to a static send instead of a closure se… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/issue12284_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/resolved_visitor.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/resolved_visitor.dart (revision 26111)
+++ sdk/lib/_internal/compiler/implementation/resolved_visitor.dart (working copy)
@@ -10,22 +10,23 @@
ResolvedVisitor(this.elements);
R visitSend(Send node) {
+ Element element = elements[node];
if (node.isSuperCall) {
return visitSuperSend(node);
} else if (node.isOperator) {
return visitOperatorSend(node);
} else if (node.isPropertyAccess) {
- Element element = elements[node];
if (!Elements.isUnresolved(element) && element.impliesType()) {
// A reference to a class literal, typedef or type variable.
return visitTypeReferenceSend(node);
} else {
return visitGetterSend(node);
}
- } else if (Elements.isClosureSend(node, elements[node])) {
+ } else if (element != null && Initializers.isConstructorRedirect(node)) {
+ return visitStaticSend(node);
+ } else if (Elements.isClosureSend(node, element)) {
return visitClosureSend(node);
} else {
- Element element = elements[node];
if (Elements.isUnresolved(element)) {
if (element == null) {
// Example: f() with 'f' unbound.
« no previous file with comments | « no previous file | tests/language/issue12284_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698