Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 2317083003: Use type aliases for StaticElementList/StaticNodeList (Closed)

Created:
4 years, 3 months ago by rwlbuis
Modified:
4 years, 3 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use type aliases for StaticElementList/StaticNodeList We currently have a mixture of using typedefs and type aliases for forward referencing StaticElementList and StaticNodeElement. Stick to type aliases since they are more modern and a C++11 allowed feature in Chromium. Committed: https://crrev.com/416c3ba5471eae5239502e4edee4298973d8601c Cr-Commit-Position: refs/heads/master@{#417085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/MutationRecord.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/SelectorQuery.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StaticNodeList.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
rwlbuis
PTAL.
4 years, 3 months ago (2016-09-07 17:07:45 UTC) #3
kouhei (in TOK)
lgtm
4 years, 3 months ago (2016-09-07 18:23:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317083003/1
4 years, 3 months ago (2016-09-07 18:23:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 22:16:11 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 22:19:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/416c3ba5471eae5239502e4edee4298973d8601c
Cr-Commit-Position: refs/heads/master@{#417085}

Powered by Google App Engine
This is Rietveld 408576698