Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: components/memory_pressure/memory_pressure_stats_collector.cc

Issue 2317083002: Remove unused metric from memory_pressure component. (Closed)
Patch Set: Fix unittest. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/memory_pressure/memory_pressure_stats_collector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/memory_pressure/memory_pressure_stats_collector.cc
diff --git a/components/memory_pressure/memory_pressure_stats_collector.cc b/components/memory_pressure/memory_pressure_stats_collector.cc
index 1d080dae8c60091c6b81aca41e8818cc5c557aa1..b4ff482bd4e0331fc00d9f2a9c0e4878dd807400 100644
--- a/components/memory_pressure/memory_pressure_stats_collector.cc
+++ b/components/memory_pressure/memory_pressure_stats_collector.cc
@@ -50,37 +50,6 @@ MemoryPressureLevel MemoryPressureLevelFromUmaEnumValue(
return MemoryPressureListener::MEMORY_PRESSURE_LEVEL_NONE;
}
-// Converts a pressure state change to an UMA enumeration value.
-MemoryPressureLevelChangeUMA MemoryPressureLevelChangeToUmaEnumValue(
- MemoryPressureLevel old_level,
- MemoryPressureLevel new_level) {
- switch (old_level) {
- case MemoryPressureListener::MEMORY_PRESSURE_LEVEL_NONE: {
- if (new_level == MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE)
- return UMA_MEMORY_PRESSURE_LEVEL_CHANGE_NONE_TO_MODERATE;
- if (new_level == MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL)
- return UMA_MEMORY_PRESSURE_LEVEL_CHANGE_NONE_TO_CRITICAL;
- break; // Should never happen; handled by the NOTREACHED below.
- }
- case MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE: {
- if (new_level == MemoryPressureListener::MEMORY_PRESSURE_LEVEL_NONE)
- return UMA_MEMORY_PRESSURE_LEVEL_CHANGE_MODERATE_TO_NONE;
- if (new_level == MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL)
- return UMA_MEMORY_PRESSURE_LEVEL_CHANGE_MODERATE_TO_CRITICAL;
- break; // Should never happen; handled by the NOTREACHED below.
- }
- case MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL: {
- if (new_level == MemoryPressureListener::MEMORY_PRESSURE_LEVEL_NONE)
- return UMA_MEMORY_PRESSURE_LEVEL_CHANGE_CRITICAL_TO_MODERATE;
- if (new_level == MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE)
- return UMA_MEMORY_PRESSURE_LEVEL_CHANGE_CRITICAL_TO_MODERATE;
- break; // Should never happen; handled by the NOTREACHED below.
- }
- }
- NOTREACHED();
- return UMA_MEMORY_PRESSURE_LEVEL_CHANGE_NONE_TO_MODERATE;
-}
-
} // namespace
MemoryPressureStatsCollector::MemoryPressureStatsCollector(
@@ -149,10 +118,7 @@ void MemoryPressureStatsCollector::ReportCumulativeTime(
void MemoryPressureStatsCollector::ReportLevelChange(
MemoryPressureLevel old_pressure_level,
MemoryPressureLevel new_pressure_level) {
- UMA_HISTOGRAM_ENUMERATION("Memory.PressureLevelChange",
- MemoryPressureLevelChangeToUmaEnumValue(
- old_pressure_level, new_pressure_level),
- UMA_MEMORY_PRESSURE_LEVEL_CHANGE_COUNT);
+ // TODO(chrisha): Report Memory.PressureLevelChange when this code is in use.
}
} // namespace memory_pressure
« no previous file with comments | « no previous file | components/memory_pressure/memory_pressure_stats_collector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698