Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2317073003: Rename PlatformScreen implementations. (Closed)

Created:
4 years, 3 months ago by kylechar
Modified:
4 years, 3 months ago
Reviewers:
rjkroege, msw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename PlatformScreen implementations. Improve naming of PlatformScreen implementations. BUG=none Committed: https://crrev.com/15467f9cfb2ae57c63566da157c079e82b19c8ba Cr-Commit-Position: refs/heads/master@{#417036}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment. #

Patch Set 3 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -421 lines) Patch
M services/ui/display/BUILD.gn View 1 chunk +5 lines, -5 lines 0 comments Download
D services/ui/display/platform_screen_impl.h View 1 chunk +0 lines, -40 lines 0 comments Download
D services/ui/display/platform_screen_impl.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D services/ui/display/platform_screen_impl_ozone.h View 1 chunk +0 lines, -100 lines 0 comments Download
D services/ui/display/platform_screen_impl_ozone.cc View 1 chunk +0 lines, -184 lines 0 comments Download
A + services/ui/display/platform_screen_ozone.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + services/ui/display/platform_screen_ozone.cc View 8 chunks +14 lines, -14 lines 0 comments Download
M services/ui/display/platform_screen_ozone_unittests.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
A + services/ui/display/platform_screen_stub.h View 1 3 chunks +10 lines, -10 lines 0 comments Download
A + services/ui/display/platform_screen_stub.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
kylechar
+msw for OWNERS. +rjkroege FYI.
4 years, 3 months ago (2016-09-07 14:15:37 UTC) #2
msw
lgtm https://codereview.chromium.org/2317073003/diff/1/services/ui/display/platform_screen_stub.h File services/ui/display/platform_screen_stub.h (right): https://codereview.chromium.org/2317073003/diff/1/services/ui/display/platform_screen_stub.h#newcode16 services/ui/display/platform_screen_stub.h:16: // PlatformScreenStub provides the necessary functionality to configure ...
4 years, 3 months ago (2016-09-07 15:29:51 UTC) #3
kylechar
Thanks msw! https://codereview.chromium.org/2317073003/diff/1/services/ui/display/platform_screen_stub.h File services/ui/display/platform_screen_stub.h (right): https://codereview.chromium.org/2317073003/diff/1/services/ui/display/platform_screen_stub.h#newcode16 services/ui/display/platform_screen_stub.h:16: // PlatformScreenStub provides the necessary functionality to ...
4 years, 3 months ago (2016-09-07 15:34:33 UTC) #4
rjkroege
lgtm
4 years, 3 months ago (2016-09-07 17:13:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317073003/20001
4 years, 3 months ago (2016-09-07 17:51:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/231573)
4 years, 3 months ago (2016-09-07 18:16:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317073003/40001
4 years, 3 months ago (2016-09-07 18:32:32 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-07 19:52:57 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 19:55:43 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/15467f9cfb2ae57c63566da157c079e82b19c8ba
Cr-Commit-Position: refs/heads/master@{#417036}

Powered by Google App Engine
This is Rietveld 408576698