LibYuv GN: Add GN test targets.

BUILD.gn

Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index fed8a68c0d58b15c02df72450e0193997143de3c..ab8ff4339960678e338ebc612a24abeb52ba4c29 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -6,18 +6,22 @@
 # in the file PATENTS. All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
-import("//build/config/arm.gni")
-import("//build/config/sanitizers/sanitizers.gni")
+import("libyuv.gni")
+import("//testing/test.gni")
 
 config("libyuv_config") {
   include_dirs = [
     ".",

[kjellander_chromium, 2016/09/07 14:29:26]

No need to include . for GN

     "include",
   ]
+  if (is_android && current_cpu == "arm64") {

[kjellander_chromium, 2016/09/07 14:29:26]

Is linking failing without these on Android? I see they come from
https://cs.chromium.org/chromium/src/third_party/libyuv/libyuv.gyp?rcl=0&l=126

Frank: Can you explain why they're needed?

+    ldflags = [ "-Wl,--dynamic-linker,/system/bin/linker64" ]
+  }
+  if (is_android && current_cpu != "arm64") {
+    ldflags = [ "-Wl,--dynamic-linker,/system/bin/linker" ]
+  }
 }
 
-use_neon = current_cpu == "arm64" || (current_cpu == "arm" && (arm_use_neon || arm_optionally_use_neon))
-
 static_library("libyuv") {
   sources = [
     # Headers
@@ -79,7 +83,7 @@ static_library("libyuv") {
     "source/video_common.cc",
   ]
 
-   public_configs = [ ":libyuv_config" ]
+  public_configs = [ ":libyuv_config" ]
 
   defines = []
   deps = []
@@ -89,7 +93,7 @@ static_library("libyuv") {
     deps += [ "//third_party:jpeg" ]
   }
 
-  if (use_neon) {
+  if (libyuv_use_neon) {
     deps += [ ":libyuv_neon" ]
   }
 
@@ -100,7 +104,7 @@ static_library("libyuv") {
   }
 }
 
-if (use_neon) {
+if (libyuv_use_neon) {
   static_library("libyuv_neon") {
     sources = [
       # ARM Source Files
@@ -122,3 +126,129 @@ if (use_neon) {
     }
   }
 }
+
+if (libyuv_include_tests) {
+  config("libyuv_unittest_config") {
+    defines = [ "GTEST_RELATIVE_PATH" ]
+    cflags = [
+      "-Wno-sign-compare",
+      "-Wno-unused-variable"
+    ]
+  }
+
+  test("libyuv_unittest") {
+    testonly = true
+
+    sources = [
+      # headers
+      "unit_test/unit_test.h",
+      # sources
+      "unit_test/basictypes_test.cc",
+      "unit_test/compare_test.cc",
+      "unit_test/color_test.cc",
+      "unit_test/convert_test.cc",
+      "unit_test/cpu_test.cc",
+      "unit_test/math_test.cc",
+      "unit_test/planar_test.cc",
+      "unit_test/rotate_argb_test.cc",
+      "unit_test/rotate_test.cc",
+      "unit_test/scale_argb_test.cc",
+      "unit_test/scale_test.cc",
+      "unit_test/unit_test.cc",
+      "unit_test/video_common_test.cc",
+    ]
+
+    deps = [
+      ":libyuv",
+      "//testing/gtest",
+      "//third_party/gflags",
+    ]
+
+    public_deps = [ "//testing/gtest" ]
+    public_configs = [ ":libyuv_unittest_config" ]
+
+    defines = []
+
+    if (is_linux) {
+      cflags = [ "-fexceptions" ]
+    }
+    if (is_ios && target_cpu == "arm64") {

[kjellander_chromium, 2016/09/07 14:29:26]

nit: omit spaces around ==
(same below)

+      defines += [ "LIBYUV_DISABLE_NEON" ]
+    }
+    if (is_ios) {
+      configs -= [ "//build/config/compiler:default_symbols" ]
+      configs += [ "//build/config/compiler:symbols" ]
+      cflags = [ "-Wno-sometimes-uninitialized" ]
+    }
+    if (!is_ios && !libyuv_disable_jpeg) {
+      defines += [ "HAVE_JPEG" ]
+    }
+    if (is_android) {
+      deps += [ "//testing/android/native_test:native_test_native_code" ]
+    }
+
+    # TODO(YangZhang): These lines can be removed when high accuracy
+    # YUV to RGB to Neon is ported.
+    if ((target_cpu == "armv7" || target_cpu == "armv7s" ||
+        (target_cpu == "arm" && arm_version >= 7) || target_cpu == "arm64") &&
+        (arm_use_neon || arm_optionally_use_neon)) {
+      defines += [ "LIBYUV_NEON" ]
+    }
+
+    defines += [
+      # Enable the following 3 macros to turn off assembly for specified CPU.
+      # "LIBYUV_DISABLE_X86",
+      # "LIBYUV_DISABLE_NEON",
+      # "LIBYUV_DISABLE_MIPS",
+      # Enable the following macro to build libyuv as a shared library (dll).
+      # "LIBYUV_USING_SHARED_LIBRARY"
+    ]
+  }
+
+  executable("compare") {
+    deps = [ ":libyuv" ]

[kjellander_chromium, 2016/09/07 14:29:26]

Please order items according to the GN style guide:
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/style_g...

+    sources = [
+      # sources
+      "util/compare.cc"
+    ]
+    if (is_linux) {
+      cflags = [ "-fexceptions" ]
+    }
+  }
+
+  executable("convert") {
+    deps = [ ":libyuv" ]
+    sources = [
+      # sources
+      "util/convert.cc"
+    ]
+    if (is_linux) {
+      cflags = [ "-fexceptions" ]
+    }
+  }
+
+  executable("psnr") {
+    deps = [ ":libyuv" ]
+    sources = [
+      # sources
+      "util/psnr_main.cc",
+      "util/psnr.cc",
+      "util/ssim.cc"
+    ]
+
+    if (is_ios && target_cpu == "arm64") {
+      defines = [ "LIBYUV_DISABLE_NEON" ]
+    }
+    if (!is_ios && !libyuv_disable_jpeg) {
+      defines = [ "HAVE_JPEG" ]
+    }
+  }
+
+  executable("cpuid") {
+    deps = [ ":libyuv" ]
+    sources = [
+      # sources
+      "util/cpuid.c"
+    ]
+  }
+}