Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2317013002: Run install-sysroot script before 'gn gen' on PDFium bot (Closed)

Created:
4 years, 3 months ago by borenet2
Modified:
4 years, 3 months ago
Reviewers:
borenet, mtklein, caryclark
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Run install-sysroot script before 'gn gen' on PDFium bot BUG=skia:5727 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317013002 Committed: https://skia.googlesource.com/skia/+/e72daf6116a35da5a8bbac05f11ff5a8800590d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M infra/bots/recipe_modules/flavor/pdfium_flavor.py View 1 chunk +8 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-PDFium.json View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
borenet
4 years, 3 months ago (2016-09-07 11:25:28 UTC) #5
mtklein
FWIW, there's likely a GN arg like use_sysroot that you can set to false to ...
4 years, 3 months ago (2016-09-07 12:23:05 UTC) #9
borenet
On 2016/09/07 12:23:05, mtklein wrote: > FWIW, there's likely a GN arg like use_sysroot that ...
4 years, 3 months ago (2016-09-07 13:22:24 UTC) #10
caryclark
lgtm
4 years, 3 months ago (2016-09-07 14:54:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317013002/1
4 years, 3 months ago (2016-09-07 15:33:25 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 15:34:16 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e72daf6116a35da5a8bbac05f11ff5a8800590d5

Powered by Google App Engine
This is Rietveld 408576698