Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2316983002: Change capitalization FullScreen->Fullscreen where possible in Blink (Closed)

Created:
4 years, 3 months ago by foolip
Modified:
4 years, 3 months ago
CC:
aboxhall+watch_chromium.org, aboxhall, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, darin-cc_chromium.org, dcheng, dglazkov+blink, dmazzoni+watch_chromium.org, dmazzoni, dshwang, dtseng+watch_chromium.org, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, haraken, jam, jchaffraix+rendering, je_julie, kinuko+watch, leviw+renderwatch, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org, mlamouri+watch-screen-orientation_chromium.org, nektar+watch_chromium.org, nektarios, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, nessy, slimming-paint-reviews_chromium.org, Srirama, szager+layoutwatch_chromium.org, vcarbune.chromium, yuzo+watch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change capitalization FullScreen->Fullscreen where possible in Blink The remaining cases are either connected to the web-exposed APIs or in code expected to be removed soon as part of the top-layer rewrite. BUG=240576 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/999da6c00b72260865c2633a887038aa0bcad5cb Cr-Commit-Position: refs/heads/master@{#416937}

Patch Set 1 #

Patch Set 2 : update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -92 lines) Patch
M content/public/browser/screen_orientation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/screen_orientation/screen_orientation_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/full-screen-request-rejected-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/full-screen-request-removed-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/full-screen-restrictions-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/video-fail-to-enter-full-screen-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSliderThumb.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXSlider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/LockOrientationCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/ThemeTypes.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/FullscreenController.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/FullscreenController.cpp View 6 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/public/platform/modules/screen_orientation/WebLockOrientationError.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
foolip
Jochen, PTAL, trivial renaming.
4 years, 3 months ago (2016-09-07 12:40:32 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-07 14:26:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316983002/20001
4 years, 3 months ago (2016-09-07 14:46:05 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 14:50:38 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 14:51:56 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/999da6c00b72260865c2633a887038aa0bcad5cb
Cr-Commit-Position: refs/heads/master@{#416937}

Powered by Google App Engine
This is Rietveld 408576698