Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: ipc/ipc_mojo_bootstrap.cc

Issue 2316963005: Reworks Channel pausing behavior (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_mojo_bootstrap.h ('k') | ipc/ipc_sync_channel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_mojo_bootstrap.cc
diff --git a/ipc/ipc_mojo_bootstrap.cc b/ipc/ipc_mojo_bootstrap.cc
index affcf18b9df2d6cb8bbf2a5b1d8f5b5059127d7f..1552f315d136cc90fea4f030355306749fbb048f 100644
--- a/ipc/ipc_mojo_bootstrap.cc
+++ b/ipc/ipc_mojo_bootstrap.cc
@@ -72,9 +72,14 @@ class ChannelAssociatedGroupController
base::Unretained(this)));
}
- void Start() {
- DCHECK(!started_);
- started_ = true;
+ void Pause() {
+ DCHECK(!paused_);
+ paused_ = true;
+ }
+
+ void Unpause() {
+ DCHECK(paused_);
+ paused_ = false;
}
void FlushOutgoingMessages() {
@@ -473,9 +478,7 @@ class ChannelAssociatedGroupController
bool SendMessage(mojo::Message* message) {
if (task_runner_->BelongsToCurrentThread()) {
DCHECK(thread_checker_.CalledOnValidThread());
- if (!connector_ || !started_) {
- // Pipe may not be bound yet or the channel may still be paused, so we
- // queue the message.
+ if (!connector_ || paused_) {
outgoing_messages_.emplace_back(std::move(*message));
return true;
}
@@ -760,7 +763,7 @@ class ChannelAssociatedGroupController
scoped_refptr<base::SingleThreadTaskRunner> proxy_task_runner_;
const bool set_interface_id_namespace_bit_;
- bool started_ = false;
+ bool paused_ = false;
std::unique_ptr<mojo::Connector> connector_;
mojo::FilterChain filters_;
mojo::PipeControlMessageHandler control_message_handler_;
@@ -812,8 +815,12 @@ class MojoBootstrapImpl : public MojoBootstrap {
delegate_->OnPipesAvailable(std::move(sender), std::move(receiver));
}
- void Start() override {
- controller_->Start();
+ void Pause() override {
+ controller_->Pause();
+ }
+
+ void Unpause() override {
+ controller_->Unpause();
}
void Flush() override {
« no previous file with comments | « ipc/ipc_mojo_bootstrap.h ('k') | ipc/ipc_sync_channel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698