Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: ipc/ipc_channel.h

Issue 2316963005: Reworks Channel pausing behavior (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ipc/ipc_channel_common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel.h
diff --git a/ipc/ipc_channel.h b/ipc/ipc_channel.h
index c1e163c4ec03c5840a59304a155d4ea8fa881f90..11b9119b28bd500f1ad2d8ba4e5a37cdeaee7c09 100644
--- a/ipc/ipc_channel.h
+++ b/ipc/ipc_channel.h
@@ -222,21 +222,15 @@ class IPC_EXPORT Channel : public Endpoint {
// implementation.
virtual bool Connect() WARN_UNUSED_RESULT = 0;
- // Similar to (and exclusive to) Connect() above, but blocks outgoing messages
- // until a future call to Unpause().
- //
- // Not all implementations support ConnectPaused(). Note that this interface
- // exists only to facilitate weird behavior where some Channel consumers want
- // to force some early messages to be transmitted before ones which were sent
- // earlier. This allows that to be done without the consumer implementing
- // their own message queueing support which may be incompatible with the
- // Channel's internal queueing behavior.
- virtual bool ConnectPaused() WARN_UNUSED_RESULT;
-
- // Unpause the pipe. This allows subsequent Send() calls to transmit messages
- // immediately, without queueing. If |flush| is true, any messages queued
- // while paused will be flushed immediately upon unpausing. Otherwise you must
- // call Flush() explicitly.
+ // Pause the channel. Subsequent sends will be queued internally until
+ // Unpause() is called and the channel is flushed either by Unpause() or a
+ // subsequent call to Flush().
+ virtual void Pause();
+
+ // Unpause the channel. This allows subsequent Send() calls to transmit
+ // messages immediately, without queueing. If |flush| is true, any messages
+ // queued while paused will be flushed immediately upon unpausing. Otherwise
+ // you must call Flush() explicitly.
//
// Not all implementations support Unpause(). See ConnectPaused() above for
// details.
« no previous file with comments | « no previous file | ipc/ipc_channel_common.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698