Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2316963003: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in InputMethodController::setComposit… (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in InputMethodController::setCompositionFromExistingText BUG=590369 Committed: https://crrev.com/d2b6e61ec89458b9ddbc3562e04dbfd4ba425e04 Cr-Commit-Position: refs/heads/master@{#417196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-08 01:40:38 UTC) #6
yosin_UTC9
lgtm
4 years, 3 months ago (2016-09-08 04:05:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316963003/1
4 years, 3 months ago (2016-09-08 04:05:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/255234)
4 years, 3 months ago (2016-09-08 04:12:24 UTC) #11
tkent
lgtm
4 years, 3 months ago (2016-09-08 04:41:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316963003/1
4 years, 3 months ago (2016-09-08 05:24:05 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 05:42:38 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 05:44:40 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2b6e61ec89458b9ddbc3562e04dbfd4ba425e04
Cr-Commit-Position: refs/heads/master@{#417196}

Powered by Google App Engine
This is Rietveld 408576698