[Material][Mac] Action on Mouse Down for User Account Button

[Material][Mac] Action on Mouse Down for User Account Button

BUG=590917

[spqchan, 2016-09-07 00:26:51]

spqchan@chromium.org changed reviewers:
+ shrike@chromium.org

[spqchan, 2016-09-07 00:26:51]

PTAL

[shrike, 2016-09-07 23:58:22]

lgtm (except for my comment on the bug that I don't think the window needs to
move down at all).

[spqchan, 2016-09-08 00:36:58]

Description was changed from

==========
[Material][Mac] Details for MD User Account Button

- Action should happen on a mouse down
- Dialog needs to appear 1 px lower

BUG=643941, 590917
==========

to

==========
[Material][Mac] Action on Mouse Down for User Account Button

BUG= 590917
==========

[spqchan, 2016-09-08 00:37:33]

spqchan@chromium.org changed reviewers:
+ avi@chromium.org

[spqchan, 2016-09-08 00:37:33]

Awesome, removed the dialog changes then.

+avi for OWNER

[Avi (use Gerrit), 2016-09-08 01:42:17]

On 2016/09/08 00:37:33, spqchan wrote:
> Awesome, removed the dialog changes then.
> 
> +avi for OWNER

Why? Buttons don't do this on the Mac.

[spqchan, 2016-09-08 16:39:17]

On 2016/09/08 01:42:17, Avi (OOO 8-12 September) wrote:
> On 2016/09/08 00:37:33, spqchan wrote:
> > Awesome, removed the dialog changes then.
> > 
> > +avi for OWNER
> 
> Why? Buttons don't do this on the Mac.

This is actually the style that's been happening with MacViews and Materials.
The mouse down makes it seem more responsive.

[Avi (use Gerrit), 2016-09-08 16:40:16]

sigh

LGTM

Why do we have to be gratuitously different from the platform? :(

[spqchan, 2016-09-08 16:40:28]

spqchan@chromium.org changed reviewers:
+ ccameron@chromium.org

[spqchan, 2016-09-08 16:40:29]

+ccameron for OWNERS since avi is in OOO

[shrike, 2016-09-08 16:42:06]

Hi avi@, what exactly are you pointing out is different from the platform?

[spqchan, 2016-09-08 16:43:52]

spqchan@chromium.org changed reviewers:
- ccameron@chromium.org

[spqchan, 2016-09-08 16:43:53]

And removing ccameron (Sorry avi!)

[Avi (use Gerrit), 2016-09-08 18:35:46]

On 2016/09/08 16:43:53, spqchan wrote:
> And removing ccameron (Sorry avi!)

Buttons trigger on mouse-up, not mouse-down. Menus don't, but this isn't a menu.

[shrike, 2016-09-08 19:00:17]

On 2016/09/08 18:35:46, Avi (OOO 8-12 September) wrote:
> On 2016/09/08 16:43:53, spqchan wrote:
> > And removing ccameron (Sorry avi!)
> 
> Buttons trigger on mouse-up, not mouse-down. Menus don't, but this isn't a
menu.

Ooo, that's right. And that's because when a user clicks and holds a button they
can abort the button press by dragging the mouse outside of the button's bounds.

spqchan@, please avoid landing this change until I have a chance to talk to the
designer.

[spqchan, 2016-09-13 21:39:35]

On 2016/09/08 19:00:17, shrike wrote:
> On 2016/09/08 18:35:46, Avi (OOO 8-12 September) wrote:
> > On 2016/09/08 16:43:53, spqchan wrote:
> > > And removing ccameron (Sorry avi!)
> > 
> > Buttons trigger on mouse-up, not mouse-down. Menus don't, but this isn't a
> menu.
> 
> Ooo, that's right. And that's because when a user clicks and holds a button
they
> can abort the button press by dragging the mouse outside of the button's
bounds.
> 
> spqchan@, please avoid landing this change until I have a chance to talk to
the
> designer.

Closing this because it's been decided to not do mouse-down

[spqchan, 2016-09-13 21:39:36]

On 2016/09/08 19:00:17, shrike wrote:
> On 2016/09/08 18:35:46, Avi (OOO 8-12 September) wrote:
> > On 2016/09/08 16:43:53, spqchan wrote:
> > > And removing ccameron (Sorry avi!)
> > 
> > Buttons trigger on mouse-up, not mouse-down. Menus don't, but this isn't a
> menu.
> 
> Ooo, that's right. And that's because when a user clicks and holds a button
they
> can abort the button press by dragging the mouse outside of the button's
bounds.
> 
> spqchan@, please avoid landing this change until I have a chance to talk to
the
> designer.

Closing this because it's been decided to not do mouse-down