Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Issue 2316833002: Add a dependency check for polymer-css-build to reproduce.sh (Closed)

Created:
4 years, 3 months ago by Dan Beam
Modified:
4 years, 3 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a dependency check for polymer-css-build to reproduce.sh R=tsergeant@chromium.org BUG=none TEST=reproduce.sh blows up earlier when polymer-css-build npm module not installed NOTRY=true Committed: https://crrev.com/e1937017280dc1aa2a69dd85c0bfc8716a9daf27 Cr-Commit-Position: refs/heads/master@{#416775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/polymer/v1_0/reproduce.sh View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Dan Beam
4 years, 3 months ago (2016-09-06 23:09:15 UTC) #1
tsergeant
lgtm
4 years, 3 months ago (2016-09-06 23:10:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316833002/1
4 years, 3 months ago (2016-09-06 23:31:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 23:36:29 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 23:39:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1937017280dc1aa2a69dd85c0bfc8716a9daf27
Cr-Commit-Position: refs/heads/master@{#416775}

Powered by Google App Engine
This is Rietveld 408576698