Maybe avoid a copy in CPDF_RenderStatus::SelectClipPath

Maybe avoid a copy in CPDF_RenderStatus::SelectClipPath

Use the shared copy-on-write version instead of the underlying
CFX_GraphStateData since it may not always get modified.

Committed: https://pdfium.googlesource.com/pdfium/+/85a65b310924eacbd2e720162cc7547153b03077

[Tom Sepez, 2016-09-06 22:36:23]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 22:36:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-06 22:37:12]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-09-06 22:37:13]

Dan, for review.

[commit-bot: I haz the power, 2016-09-06 22:48:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 22:48:37]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-09-07 12:55:40]

lgtm w/ question.

https://codereview.chromium.org/2316823002/diff/1/core/fpdfapi/fpdf_render/fp...
File core/fpdfapi/fpdf_render/fpdf_render.cpp (right):

https://codereview.chromium.org/2316823002/diff/1/core/fpdfapi/fpdf_render/fp...
core/fpdfapi/fpdf_render/fpdf_render.cpp:660: &path_matrix,
graphState.GetObject());
Is this copy needed or can the CFX_GraphState be passed through here as well?

[Tom Sepez, 2016-09-07 16:35:11]

https://codereview.chromium.org/2316823002/diff/1/core/fpdfapi/fpdf_render/fp...
File core/fpdfapi/fpdf_render/fpdf_render.cpp (right):

https://codereview.chromium.org/2316823002/diff/1/core/fpdfapi/fpdf_render/fp...
core/fpdfapi/fpdf_render/fpdf_render.cpp:660: &path_matrix,
graphState.GetObject());
On 2016/09/07 12:55:40, dsinclair wrote:
> Is this copy needed or can the CFX_GraphState be passed through here as well?

I'll get to that eventually.  Turns out the m_pDevice methods don't modify the
object, but having it peek at the internals isn't desirable.

[Tom Sepez, 2016-09-07 16:35:15]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-09-07 16:35:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 16:35:39]

Description was changed from

==========
Maybe avoid a copy in CPDF_RenderStatus::SelectClipPath

Use the shared copy-on-write version instead of the underlying
CFX_GraphStateData since it may not always get modified.
==========

to

==========
Maybe avoid a copy in CPDF_RenderStatus::SelectClipPath

Use the shared copy-on-write version instead of the underlying
CFX_GraphStateData since it may not always get modified.

Committed:
https://pdfium.googlesource.com/pdfium/+/85a65b310924eacbd2e720162cc7547153b0...
==========

[commit-bot: I haz the power, 2016-09-07 16:35:40]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/85a65b310924eacbd2e720162cc7547153b0...