Use tcmalloc on Linux

Use tcmalloc on Linux

Statically linking in the tcmalloc code is enough
to override the built-in malloc. I have this set up to
exclude the code for collecting heap profiles in a
Product build. There's still about a 230KB increase in
binary size, though. I think this isn't a big problem
since right now this is enabled only for server Linux.

product binary size:
before x64: 9569600
after  x64: 9807840
increase: 238240 (2.5%)

before ia32: 9122836
after  ia32: 9360944
increase: 238108 (2.6%)

before mips: 9418680
after  mips: 9640940
increase: 222260 (2.4%)

InitialRSS:
product:
before x64: 6307840
after x64:  7430144
increase: 1122304 (17.8%)

release (--no-profiler)
before x64: 7843840
after x64:  9207808
increase: 1363968 (17.4%)

R=asiva@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/44a04f18f9232c25e668b594ed6f21db54ca49cf

[zra, 2016-09-07 20:00:02]

Description was changed from

==========
Use tcmalloc on Linux
==========

to

==========
Use tcmalloc on Linux

product binary size
before x64: 9569600
after  x64: 9807840
increase: 238240

before ia32: 9122836
after  ia32: 9360944
increase: 238108

before mips: 9418680
after  mips: 9640940
increase: 222260
==========

[zra, 2016-09-08 19:41:35]

Description was changed from

==========
Use tcmalloc on Linux

product binary size
before x64: 9569600
after  x64: 9807840
increase: 238240

before ia32: 9122836
after  ia32: 9360944
increase: 238108

before mips: 9418680
after  mips: 9640940
increase: 222260
==========

to

==========
Use tcmalloc on Linux

Statically linking in the tcmalloc code is enough
to override the built-in malloc. I have this set up to
exclude the code for collecting heap profiles in a
Product build. There's still about a 230KB increase in
binary size, though. I think this isn't a big problem
since right now this is enabled only for server Linux.

product binary size
before x64: 9569600
after  x64: 9807840
increase: 238240

before ia32: 9122836
after  ia32: 9360944
increase: 238108

before mips: 9418680
after  mips: 9640940
increase: 222260
==========

[zra, 2016-09-08 19:41:35]

Description was changed from

==========
Use tcmalloc on Linux

product binary size
before x64: 9569600
after  x64: 9807840
increase: 238240

before ia32: 9122836
after  ia32: 9360944
increase: 238108

before mips: 9418680
after  mips: 9640940
increase: 222260
==========

to

==========
Use tcmalloc on Linux

Statically linking in the tcmalloc code is enough
to override the built-in malloc. I have this set up to
exclude the code for collecting heap profiles in a
Product build. There's still about a 230KB increase in
binary size, though. I think this isn't a big problem
since right now this is enabled only for server Linux.

product binary size
before x64: 9569600
after  x64: 9807840
increase: 238240

before ia32: 9122836
after  ia32: 9360944
increase: 238108

before mips: 9418680
after  mips: 9640940
increase: 222260
==========

[zra, 2016-09-08 19:41:52]

zra@google.com changed reviewers:
+ asiva@google.com

[zra, 2016-09-09 18:17:35]

Description was changed from

==========
Use tcmalloc on Linux

Statically linking in the tcmalloc code is enough
to override the built-in malloc. I have this set up to
exclude the code for collecting heap profiles in a
Product build. There's still about a 230KB increase in
binary size, though. I think this isn't a big problem
since right now this is enabled only for server Linux.

product binary size
before x64: 9569600
after  x64: 9807840
increase: 238240

before ia32: 9122836
after  ia32: 9360944
increase: 238108

before mips: 9418680
after  mips: 9640940
increase: 222260
==========

to

==========
Use tcmalloc on Linux

Statically linking in the tcmalloc code is enough
to override the built-in malloc. I have this set up to
exclude the code for collecting heap profiles in a
Product build. There's still about a 230KB increase in
binary size, though. I think this isn't a big problem
since right now this is enabled only for server Linux.

product binary size:
before x64: 9569600
after  x64: 9807840
increase: 238240 (2.5%)

before ia32: 9122836
after  ia32: 9360944
increase: 238108 (2.6%)

before mips: 9418680
after  mips: 9640940
increase: 222260 (2.4%)

InitialRSS:
product:
before x64: 6307840
after x64:  7430144
increase: 1122304 (17.8%)

release (--no-profiler)
before x64: 7843840
after x64:  9207808
increase: 1363968 (17.4%)
==========

[zra, 2016-09-13 15:58:59]

zra@google.com changed reviewers:
+ whesse@google.com

[zra, 2016-09-13 15:59:00]

Question for whesse@ about the github mirror.

https://codereview.chromium.org/2316813002/diff/110001/DEPS
File DEPS (right):

https://codereview.chromium.org/2316813002/diff/110001/DEPS#newcode173
DEPS:173: "https://github.com/gperftools/gperftools.git" +
Bill, could we put this in the github mirror? Or is this okay to pull from
github?

[Bill Hesse, 2016-09-14 08:44:49]

LGTM.  The wiki page about adding third-party dependencies says to wait until
the mirror is up before adding it.  I hve filed
https://bugs.chromium.org/p/chromium/issues/detail?id=646747 to mirror the repo.

[zra, 2016-09-14 18:27:50]

Updated to use the github mirror.

[zra, 2016-09-15 20:33:45]

@asiva, did you have any comments?

[siva, 2016-09-16 00:44:31]

lgtm

sorry didn't realize you were waiting for me.

[siva, 2016-09-16 00:44:33]

lgtm

sorry didn't realize you were waiting for me.

[zra, 2016-09-16 15:24:57]

Description was changed from

==========
Use tcmalloc on Linux

Statically linking in the tcmalloc code is enough
to override the built-in malloc. I have this set up to
exclude the code for collecting heap profiles in a
Product build. There's still about a 230KB increase in
binary size, though. I think this isn't a big problem
since right now this is enabled only for server Linux.

product binary size:
before x64: 9569600
after  x64: 9807840
increase: 238240 (2.5%)

before ia32: 9122836
after  ia32: 9360944
increase: 238108 (2.6%)

before mips: 9418680
after  mips: 9640940
increase: 222260 (2.4%)

InitialRSS:
product:
before x64: 6307840
after x64:  7430144
increase: 1122304 (17.8%)

release (--no-profiler)
before x64: 7843840
after x64:  9207808
increase: 1363968 (17.4%)
==========

to

==========
Use tcmalloc on Linux

Statically linking in the tcmalloc code is enough
to override the built-in malloc. I have this set up to
exclude the code for collecting heap profiles in a
Product build. There's still about a 230KB increase in
binary size, though. I think this isn't a big problem
since right now this is enabled only for server Linux.

product binary size:
before x64: 9569600
after  x64: 9807840
increase: 238240 (2.5%)

before ia32: 9122836
after  ia32: 9360944
increase: 238108 (2.6%)

before mips: 9418680
after  mips: 9640940
increase: 222260 (2.4%)

InitialRSS:
product:
before x64: 6307840
after x64:  7430144
increase: 1122304 (17.8%)

release (--no-profiler)
before x64: 7843840
after x64:  9207808
increase: 1363968 (17.4%)

R=asiva@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/44a04f18f9232c25e668b594ed6f21db54ca49cf
==========

[zra, 2016-09-16 15:25:00]

Committed patchset #11 (id:150001) manually as
44a04f18f9232c25e668b594ed6f21db54ca49cf (presubmit successful).