Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h

Issue 2316763002: Implement v8::ValueSerializer::Delegate to throw DOMException for DataCloneError. (Closed)
Patch Set: V8ThrowException::createDOMException Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h
index d678ef67356b144a41ef66437aef80660e9bc38e..a3e6cc02f64543275468bc473d6bfdd536be534b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h
+++ b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h
@@ -25,7 +25,7 @@ class Transferables;
//
// A serializer cannot be used multiple times; it is expected that its serialize
// method will be invoked exactly once.
-class V8ScriptValueSerializer {
+class GC_PLUGIN_IGNORE("https://crbug.com/644725") V8ScriptValueSerializer : public v8::ValueSerializer::Delegate {
STACK_ALLOCATED();
WTF_MAKE_NONCOPYABLE(V8ScriptValueSerializer);
public:
@@ -35,9 +35,13 @@ public:
private:
void transfer(Transferables*, ExceptionState&);
+ // v8::ValueSerializer::Delegate
+ void ThrowDataCloneError(v8::Local<v8::String> message) override;
+
RefPtr<ScriptState> m_scriptState;
RefPtr<SerializedScriptValue> m_serializedScriptValue;
v8::ValueSerializer m_serializer;
+ const ExceptionState* m_exceptionState = nullptr;
#if DCHECK_IS_ON()
bool m_serializeInvoked = false;
#endif

Powered by Google App Engine
This is Rietveld 408576698