Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2316633003: Copy data bytes in Web Crypto's importKey() and verify() operations (Closed)

Created:
4 years, 3 months ago by eroman
Modified:
4 years, 3 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy data bytes in Web Crypto's importKey() and verify() operations BEFORE normalizing the algorithm. This matches the change in the spec: https://github.com/w3c/webcrypto/commit/ccd586cc2cf0c7fe8db524622dd35b1fa39fe7c4 The motivation is consistency with other functions. Algorithm normalization might modify the data buffer. BUG=641494 Committed: https://crrev.com/523dbeff770eac1be9c6eb8b5efe41be71a2d628 Cr-Commit-Position: refs/heads/master@{#417010}

Patch Set 1 #

Patch Set 2 : checkpoint #

Patch Set 3 : add layout tests #

Messages

Total messages: 14 (9 generated)
eroman
4 years, 3 months ago (2016-09-06 23:11:16 UTC) #6
Ryan Sleevi
lgtm
4 years, 3 months ago (2016-09-07 18:41:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316633003/40001
4 years, 3 months ago (2016-09-07 18:43:35 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-07 18:48:24 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 18:50:33 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/523dbeff770eac1be9c6eb8b5efe41be71a2d628
Cr-Commit-Position: refs/heads/master@{#417010}

Powered by Google App Engine
This is Rietveld 408576698